Explain why we're not just always calling Path.GetFullPath

xoofx · Jul 25, 2024 · e12f214 · e12f214
1 parent f63488d
commit e12f214
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/Zio/FileSystems/PhysicalFileSystem.cs b/src/Zio/FileSystems/PhysicalFileSystem.cs
@@ -982,6 +982,8 @@ protected override UPath ConvertPathFromInternalImpl(string innerPath)
             if (innerPath.StartsWith(@"\\", StringComparison.Ordinal) || innerPath.StartsWith(@"\?", StringComparison.Ordinal))
                 throw new NotSupportedException($"Path starting with `\\\\` or `\\?` are not supported -> `{innerPath}` ");
 
+            // We want to avoid using Path.GetFullPath unless absolutely necessary,
+            // because it can change the case of already rooted paths that contain a ~
             var absolutePath = HasWindowsVolumeLabel(innerPath) ? innerPath : Path.GetFullPath(innerPath);
 
             // Assert that Path.GetFullPath returned the format we expect