Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: URLs link to original numpy and pandas docs #824

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

Dawnfz-Lenfeng
Copy link
Contributor

@Dawnfz-Lenfeng Dawnfz-Lenfeng commented Oct 24, 2024

What do these changes do?

  • Add comparison tables for the APIs of numpy and pandas.
  • Modify comparison tables for Xgboost and lightgbm.

Note
The following APIs of Xorbits are inconsistent with the original ones:

  • xorbits.xgboost.predict
  • xorbits.lightgbm.predict
  • xorbits.lightgbm.predict_proba methods
  • xorbits.numpy.from_hdf5
  • xorbits.numpy.to_hdf5
  • xorbits.numpy.from_zarr
  • xorbits.numpy.to_zarr
  • xorbits.numpy.from_tiledb
  • xorbits.numpy.to_tiledb
  • xorbits.numpy.lib.arraysetops

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the documentation Improvements or additions to documentation label Oct 24, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (9700db7) to head (83086fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   83.01%   82.53%   -0.49%     
==========================================
  Files        1071     1071              
  Lines       80113    80113              
  Branches    12200    12200              
==========================================
- Hits        66509    66123     -386     
- Misses      12042    12442     +400     
+ Partials     1562     1548      -14     
Flag Coverage Δ
unittests 82.43% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit bc6d24f into xorbitsai:main Oct 24, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants