-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Impl collective communication interface #46
Merged
mergify
merged 14 commits into
xorbitsai:main
from
ChengjieLi28:feat/collective_interface
Aug 2, 2023
Merged
FEAT: Impl collective communication interface #46
mergify
merged 14 commits into
xorbitsai:main
from
ChengjieLi28:feat/collective_interface
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 93.66% 94.00% +0.34%
==========================================
Files 42 47 +5
Lines 3361 3671 +310
Branches 672 708 +36
==========================================
+ Hits 3148 3451 +303
- Misses 141 145 +4
- Partials 72 75 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
ChengjieLi28
force-pushed
the
feat/collective_interface
branch
2 times, most recently
from
July 26, 2023 08:17
c6dc28f
to
ba054be
Compare
ChengjieLi28
force-pushed
the
feat/collective_interface
branch
from
July 31, 2023 06:07
3744d8f
to
902da90
Compare
codingl2k1
reviewed
Aug 1, 2023
Co-authored-by: codingl2k1 <[email protected]>
codingl2k1
approved these changes
Aug 2, 2023
aresnow1
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #22
Tested on xorbits.
In the case of worker number 5 for tpch 100,
broadcast
is much more slower thancopy_to
.Maybe when cluster scale is very large, collective communication may speed up. But I do not know now.
See issue: https://stackoverflow.com/questions/26558189/mpi-broadcast-very-slow
Check code requirements