Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix import error on Mac #66

Merged
merged 9 commits into from
Aug 24, 2023
Merged

Conversation

YibinLiu666
Copy link
Contributor

@YibinLiu666 YibinLiu666 commented Aug 22, 2023

What do these changes do?

Related issue number

Related #65

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Aug 22, 2023
@XprobeBot XprobeBot added this to the v0.1.1 milestone Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #66 (751cd93) into main (708b539) will increase coverage by 5.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   83.53%   88.79%   +5.26%     
==========================================
  Files          46       47       +1     
  Lines        3839     3928      +89     
  Branches      744      757      +13     
==========================================
+ Hits         3207     3488     +281     
+ Misses        545      353     -192     
  Partials       87       87              
Flag Coverage Δ
unittests 88.62% <100.00%> (+5.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xoscar/collective/common.py 100.00% <100.00%> (+11.90%) ⬆️
python/xoscar/collective/core.py 78.20% <100.00%> (ø)
python/xoscar/collective/process_group.py 56.99% <100.00%> (+0.89%) ⬆️
python/xoscar/collective/utils.py 58.82% <100.00%> (ø)

... and 9 files with indirect coverage changes

ChengjieLi28
ChengjieLi28 previously approved these changes Aug 24, 2023
Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChengjieLi28 ChengjieLi28 merged commit 1632a28 into xorbitsai:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants