Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Remove StatelessActor #69

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

codingl2k1
Copy link
Contributor

@codingl2k1 codingl2k1 commented Aug 28, 2023

What do these changes do?

The StatelessActor is ambiguity, remove it and use a class attribute __xoscar_lock_type__ instead.

Related issue number

Fixes #67

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 28, 2023
@XprobeBot XprobeBot added this to the v0.1.1 milestone Aug 28, 2023
@codingl2k1 codingl2k1 changed the title Enh: Remove StatelessActor ENH: Remove StatelessActor Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7f3de4) 89.02% compared to head (7e68a37) 89.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files          48       48           
  Lines        4010     4010           
  Branches      764      764           
=======================================
  Hits         3570     3570           
  Misses        355      355           
  Partials       85       85           
Flag Coverage Δ
unittests 88.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codingl2k1 codingl2k1 marked this pull request as ready for review August 29, 2023 11:02
@XprobeBot XprobeBot modified the milestones: v0.1.1, v0.1.2 Sep 8, 2023
@XprobeBot XprobeBot modified the milestones: v0.3.0, v0.3.1, v0.3.2, v0.3.3 Jul 10, 2024
@XprobeBot XprobeBot modified the milestones: v0.3.3, v0.3.4 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] State is changing in Stateless actor
2 participants