Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass metadata along with stream creation command #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trueinsider
Copy link

In our program different streams should be handled differently in a non-deterministic way. To determine how exactly each stream should be handled we're passing metadata along with it's creation command. I believe others too can benefit from such feature and it's optional and don't break API.

@codecov-io
Copy link

codecov-io commented Mar 2, 2019

Codecov Report

Merging #46 into master will decrease coverage by 0.85%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #46      +/-   ##
=========================================
- Coverage   84.46%   83.6%   -0.86%     
=========================================
  Files           5       5              
  Lines         470     482      +12     
=========================================
+ Hits          397     403       +6     
- Misses         64      69       +5     
- Partials        9      10       +1
Impacted Files Coverage Δ
stream.go 89.78% <100%> (+0.22%) ⬆️
session.go 77.12% <61.53%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa95ef...0a6805b. Read the comment docs.

@trueinsider trueinsider force-pushed the master branch 2 times, most recently from 035af7b to 424be83 Compare March 5, 2019 07:33
@xtaci
Copy link
Owner

xtaci commented Mar 22, 2019

why not just send metadata as the first few bytes?

@trueinsider
Copy link
Author

that would be a separate packet then, which requires handling in case of error, etc. in this case you 100% have metadata once stream is open which quite simplifies code.

@trueinsider
Copy link
Author

@xtaci can you please look at this again?

@xtaci
Copy link
Owner

xtaci commented Sep 2, 2019

@xtaci can you please look at this again?
as I said before, you can just just send metadata as the first few bytes of the streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants