Generate docs for xtermjs/xterm.js #44
Conversation
ghost
changed the title
|
@parisk any comments on the approach would be great when you get a chance |
|
@Tyriar update, the issue was that the typedoc output wasn't being properly adapted for Jekyll. The documents must contain YAML Front Matters and must not be named with a leading underscore to be processed by Jekyll. I wasn't setup to test this properly until now. 😅 I'll be updating this PR with the new changes soon and we'll be able to actually see a full preview. 🍿 |
|
It's probably a good idea to add the git tag I just remembered that I haven't done anything to update |
|
@pro-src xtermjs/xterm.js@a0e2117 is a bad link? I probably won't be able to review for at least a few days |
There was a problem hiding this comment.
Thanks for this PR @pro-src! Definitely makes things better.
I would like to see the build scripts a bit more simplified, but we can do this at a later stage for sure.
For now this is a great improvement compared to the completely manual process that we have. 👏 👏 👏
P.S.: I also updated the docs version to 3.4: https://github.com/pro-src/xtermjs.org/commit/bf26d70fd6eb48f9d010287d192ca9cb8561a803
|
Awesome |
|
Yep, so you still wouldn't have needed to update this. What was that about maintainability? You guys should focus on maintaining contributors. I would still being sending PRs had @Tyriar been more reasonable. Anyways, good luck with that! |
|
@pro-src you started complaining when we suggested something different, and then you got into a shouting match with one of the contributors #54 (comment). We dodged a bullet if that's how you behave. Your legacy is immortalized in the project though with the addition of a formal code of conduct though 👌 |
|
You were shown to be wrong, you're still wrong. The so-called shouting match is where you refused to be wrong. You'd have people believe that I was typing in ALL CAPS and/or was cursing at you. I told you like it was. You didn't dodge a bullet, I was an active and friendly contributor. You lost a team member. That's sad. It's very sad that years later you're still construing things and denying the truth that you were unreasonable. My legacy, are you serious? I understand that this hurts your feelings and that you need to control the narrative because you would look bad but my legacy isn't decided by some argument with you. All attempts considered, you were a joke then and you're a joke now. Enjoy being wrong for as long as these messages exist little man. Your only hope is censorship because some people won't take your shit. |
|
I said what you did and linked to it. I'm very happy in how things worked out, it would have happened after your episode in sindresorhus/grunt-eslint#163. I suggest moving on with your life and maybe rethinking some of your values. |
|
Nice try! I'm sure you are very very happy indeed. lol, thanks for spelling out exactly what your problem is but if you want to censor me, I'm not going to let you play it off like that. This makes so much sense now, you know what I mean and you know I can't stand it. Hilarious actually LOL |
|
I'm a christian so I do believe that it's only natural that we're at odds. ;) I have no further interest. Goodbye. |
Closes xtermjs/xterm.js#1455