fix: better protect DNSCache.Set

xvzc · Aug 16, 2024 · 03df2dd · 03df2dd
1 parent 344dffc
commit 03df2dd
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/dns/dns_cache.go b/dns/dns_cache.go
@@ -33,15 +33,12 @@ func GetCache() *DNSCache {
 
 // interface function for the inner map basically.
 func (d *DNSCache) Set(key string, value string) {
-	d.cacheLock.RLock()
+	d.cacheLock.Lock()
+	defer d.cacheLock.Unlock()
 	if _, ok := d.cacheMap[key]; ok {
-		d.cacheLock.RUnlock()
 		return
 	}
-	d.cacheLock.RUnlock()
 
-	d.cacheLock.Lock()
-	defer d.cacheLock.Unlock()
 	d.cacheMap[key] = DNSCacheEntry{
 		ip: value,
 		expiry_timer: time.AfterFunc(time.Duration(*util.GetConfig().DNSCacheExpiry)*time.Second, func() {