XWIKI-21922: Introduce methods to fetch a subset of revisions in XWikiVersioningStoreInterface #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iVersioningStoreInterface * Fix date filtering for MySQL, MariaDB, PostgreSQL and Oracle
surli
approved these changes
Mar 15, 2024
vmassol
reviewed
Mar 15, 2024
...m-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/query/VersioningStoreQueryFactory.java
Outdated
Show resolved
Hide resolved
…iVersioningStoreInterface * Improve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21922
Changes
Description
Clarifications
The previous implementation of date filtering relied on timestamps stored as doubles, which can be too large for most of the DB backends we target. The queries now enforce timestamps smaller than 2038 which is the maximum supported in these databases.
Screenshots & Video
N/A
Executed Tests
N/A
Expected merging strategy