-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New options control over Animations #12050
base: master
Are you sure you want to change the base?
Conversation
If anything we want it constantly on |
https://libgdx.com/wiki/graphics/continuous-and-non-continuous-rendering From that, no, we have no real-time requirements, so we can do with rendering only when there's a reason to - meaning off. |
Right right |
Use "custom" instead "expert"? |
After vacillating over this, I think this is overcomplexity no one needs. |
Yes I get that. Though an all-or-nothing would not answer #11986 as I understand it. By the way - that movement animation is cool, but I had to resist the urge to recode it so embarcation/landing morphs the sprite from ship to land unit and vice versa... Also, it tends to be missed if auto unit cycle yanks away the view... |
Yup, but the "Some" offer is an even worse choice of wording... |
The pull request works well. I think disabling all animations saves battery life on my laptop. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Solves #11986 - luxury version
Screwnshots
Predefined sets SelectBox (the "Expert" entry allows controlling each anim individually, the other set all individual options to a preset):
Expert mode:
Notes
Gdx.graphics.isContinuousRendering
off - or did I miss anything that animates without using Gdx Actions?continuousRendering==false
into the new world perfectly - some anims weren't gated at all, to get identical behaviour we would need to create a preset with only the ungated anims on - worth it?