-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CityLocationTileRanker and Automation.kt #12343
Draft
EmperorPinguin
wants to merge
178
commits into
yairm210:master
Choose a base branch
from
EmperorPinguin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+50
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EmperorPinguin
commented
Oct 22, 2024
•
edited
Loading
edited
- I spend a little too much time trying to fix this part of AI city settling via comparing improvement yield stat values, but I din't succeed as I'm not a coder. I decided to go with an approach that works for G&K, and then a more experienced coder can optimize and generalize it as they want.
- Updates citizen assignement to let the AI better manage happiness issues.
- The value of a last copy of unique luxury is valued at 750 in line 251 in TradEvaluation, but at 500 in line 253, which is it? I decided to set them both to an intermediate value of 600.
- Updates the formula for calculating CarryOverFood (it's not entirely correct, as we'd need to take into account the food cost increase of the next citizen as well as existing CarryOverFood, but less wrong), and reduces the base food multiplyer to 2, to be more comparable to the value for citizen assignement.
- Adds evaluation for tile improvement placing and tile yields by buildings (work in progress)
I'm very much against adding ruleset-specific code, in its current state this is unmergable by my standards |
EmperorPinguin
changed the title
Update CityLocationTileRanker.kt
Update CityLocationTileRanker and Automation.kt
Oct 24, 2024
I get why (I think it's a bit ugly as well), but it's the solution I'm proposing to adress the issue, which hasn't been adressed in the past... however long Unciv exists it seems. What to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.