-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YALB-1498: Components: Card animation | YALB-1500: Components Dividers animation | YALB-1502: Components: Quote animation #278
Conversation
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…e pull quote animation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Tested in Storybook only. Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, just an awesome job! Loving this PR. All works as expected functionally. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Keeping additional motion to hover only is preferred. Users get enough feedback from the focus indicator. For elements like links and tabs/accordions a little motion is fine.
🎉 This PR is included in version 1.34.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
YALB-1498: Components: Card animation | YALB-1500: Components Dividers animation | YALB-1502: Components: Quote animation
Description of work
[data-site-animation='artistic']
.animate
class to components that have the[data-animate-item='true']
attribute.card
,quote
anddivider
componentsartistic
theme in Figma: https://www.figma.com/proto/rv05VtG2rBEo3yM9dl9n9P/YaleSites-Motion-Design?type=design&node-id=534-10966&t=LH2mcOKEqMGcdGge-0&scaling=scale-down-width&page-id=534%3A10965&starting-point-node-id=534%3A10966prefers-reduced-motion = 'true'
, using JS,[data-animate-item='true']
will change to[data-animate-item='false']
and no animation will be run. The static components will render as they should.Testing Link(s)
Functional Review Steps
Navigate to this page: https://deploy-preview-278--dev-component-library-twig.netlify.app/?path=/story/page-examples-standard-pages--with-banner
Verify that components do not animate on scroll as you scroll down the page.
Navigate to the configuration page in Storybook: https://deploy-preview-278--dev-component-library-twig.netlify.app/?path=/story/config--global-config
Set "Site Animation Theme" to
artistic
yalb-motion-artistic.mp4
quote
anddividers
on scroll, once.cards
animate on hover)yalb-motion-artistic-components.mp4
prefers-reduced-motion = 'true'
).Design Review
Accessibility Review
focus
? Currently they only rise up on hover.