Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YALB-1498: Components: Card animation | YALB-1500: Components Dividers animation | YALB-1502: Components: Quote animation #278

Merged
merged 22 commits into from
Aug 14, 2023

Conversation

joetower
Copy link
Contributor

@joetower joetower commented Jul 31, 2023

YALB-1498: Components: Card animation | YALB-1500: Components Dividers animation | YALB-1502: Components: Quote animation

Description of work

Testing Link(s)

Functional Review Steps

yalb-motion-artistic.mp4
yalb-motion-artistic-components.mp4
  • Next, in your operating system settings, disable motion (which will set prefers-reduced-motion = 'true').
    • In macOS: System Preferences > Accessibility > Display > Reduce motion.
    • In Windows 10: Settings > Ease of Access > Display > Show animations in Windows.
    • In GTK/Gnome, if gtk-enable-animations is set to false. This is configurable via GNOME Tweaks (Appearance tab or General tab, depending on version).
  • Refresh your page https://deploy-preview-278--dev-component-library-twig.netlify.app/?path=/story/page-examples-standard-pages--with-banner
  • Verify the components no longer animate but render as they should, in static form.

Design Review

  • Verify the designs match the Figma Designs
  • Cards = Version 1
  • Divider = Version 2
  • Quote = only version

Accessibility Review

  • Verify the component meets Accessibility requirements
  • Question: should the card components animate on focus? Currently they only rise up on hover.

@joetower joetower self-assigned this Jul 31, 2023
@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for dev-component-library-twig ready!

Name Link
🔨 Latest commit ae7ceaa
🔍 Latest deploy log https://app.netlify.com/sites/dev-component-library-twig/deploys/64d2b982d304220007b9a961
😎 Deploy Preview https://deploy-preview-278--dev-component-library-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joetower joetower changed the title Yalb motion epic YALB-1498: Motion: Card animation | YALB-1500: Motion: Dividers animation Aug 1, 2023
@joetower joetower changed the title YALB-1498: Motion: Card animation | YALB-1500: Motion: Dividers animation YALB-1498: Components: Card animation | YALB-1500: Components Dividers animation | YALB-1502: Components: Quote animation Aug 4, 2023
@joetower joetower marked this pull request as ready for review August 8, 2023 21:47
@joetower joetower marked this pull request as draft August 8, 2023 22:04
@joetower joetower marked this pull request as ready for review August 8, 2023 22:04
Copy link
Contributor

@codechefmarc codechefmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Tested in Storybook only. Approved!

Copy link
Contributor

@dblanken-yale dblanken-yale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, just an awesome job! Loving this PR. All works as expected functionally. Great work!

Copy link

@kara-franco kara-franco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Keeping additional motion to hover only is preferred. Users get enough feedback from the focus indicator. For elements like links and tabs/accordions a little motion is fine.

@joetower joetower merged commit c8d6d5e into develop Aug 14, 2023
6 checks passed
@joetower joetower deleted the yalb-motion-epic branch August 14, 2023 16:40
@nJim nJim mentioned this pull request Aug 18, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants