Release #430
Merged
Release #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reintroduce ys_links to storybook and the compiled output so that Drupal can still use it for now.
The new args system needs to be utilized to properly pass initial settings to storybook controls. This takes our old way and converts it to a proper args structure so we don't have to modify it all yet.
These default values in particular were causing add_attributes to bomb due to an empty href. Adding this in ensures there is one by default.
Without a default URL, the page would not load in the new storybook arcitecture.
Without actual dates, supporting twig methods would cause the page to not load.
Feels like shotgun surgery, but adding the URL in seems to allow these pages to load; it's like it's taking the link and attempting to perform actions on it, when it does not exist.
Looks like placeimg.com is no longer up. Moved to picksum.photos. If someone has a better solution let me know.
Originally, the ctaText would not populate the cost_button_text, which drives the CTA text for the button next to "Add to Calendar", resulting in an empty button with decoration. This allows it to be for both the cta_primary_content and the cost_button_text so that if the other existed, it'll use it there as well.
The callout shadow was incorrectly set for theme 4, causing it to display links in a visually terrible way. Now they are in sync to match each other.
Requested by Heather so site-improve can target them better.
Attempt to keep ONHA in tact, but change the others to have proper contrast.
Co-authored-by: ntay90
Due to accessibility concerns, visited links in callouts mimic the unvisited versions. More design/input will be needed to verify the true colors that should be used for these that meet AA standards.
There were some svgs getting through the cracks when it came to setting the SVG fill color to the current link color. This attempts to help this to be more consistent.
It seems that while Chrome respects currentColor fine, Safari is having a hard time doing this. Reading up, I noticed that you can use the color: inherit to help fix some issues with it. While this doesn't completely fix it, it helps on some components.
As a last minute effort to make link treatments follow color rules on all browsers, I'm testing out how the original non-svg version behaves. So far so good. Removed all references I made with ys_links so that we can have a central place for link treatment-specific changes.
In most cases where punctuation exists, the punctuation was a bit too close to the download icon, so we directly target that to move out a little more.
This reverts commit bf71343. This is now going to be in the ai_engine instead of here.
YSP-446: Drupal 10.3 upgrade with Node update and LinkPurpose
✅ Deploy Preview for dev-component-library-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This fixes rate limit issues we experienced in github CI.
fix(semver): update semantic-version to latest release
vinmassaro
approved these changes
Nov 5, 2024
|
🎉 This PR is included in version 1.47.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release