Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate symlinks properly for multi tests #112

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Generate symlinks properly for multi tests #112

merged 2 commits into from
Jan 17, 2022

Conversation

ingydotnet
Copy link
Member

See #107

@ingydotnet ingydotnet requested a review from perlpunk January 16, 2022 17:46
@ingydotnet ingydotnet self-assigned this Jan 16, 2022
Copy link
Member

@perlpunk perlpunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the format from
tags/empty-key/M2N8/00
to
tags/empty-key/M2N8-00

I actually created support for multitest tags in #94

I used adjusted to that new format alraedy in YAML::PP and in the YAML Test Matrix.

I don't like that it is changed again, and you approved #94

Also it's inconsistent with the data files themselves, e.g. M2N8/00/in.yaml

@ingydotnet
Copy link
Member Author

This changes the format from tags/empty-key/M2N8/00 to tags/empty-key/M2N8-00

I actually created support for multitest tags in #94

I used adjusted to that new format alraedy in YAML::PP and in the YAML Test Matrix.

I don't like that it is changed again, and you approved #94

Also it's inconsistent with the data files themselves, e.g. M2N8/00/in.yaml

Fixed in abcc9cd

@ingydotnet ingydotnet requested a review from perlpunk January 17, 2022 03:28
@ingydotnet ingydotnet merged commit 0cf2f78 into main Jan 17, 2022
@ingydotnet ingydotnet deleted the fix-tags branch January 17, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants