feat(deployment): run remote pre-hooks in separate containers

yarlson · Jan 21, 2025 · 4641d37 · 4641d37
1 parent 6bd17c7
commit 4641d37
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 4 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -69,6 +69,7 @@ type ServiceHealthCheck struct {
 type Container struct {
 	HealthCheck *ContainerHealthCheck `yaml:"health_check"`
 	ULimits     []ULimit              `yaml:"ulimits"`
+	RunOnce     bool                  `yaml:"run_once"`
 }
 
 type ULimit struct {

diff --git a/pkg/deployment/container.go b/pkg/deployment/container.go
@@ -139,7 +139,15 @@ func (d *Deployment) startContainer(container string) error {
 func (d *Deployment) createContainer(project string, service *config.Service, suffix string) error {
 	container := containerName(project, service.Name, suffix)
 
-	args := []string{"run", "-d", "--name", container, "--network", project, "--network-alias", service.Name + suffix, "--restart", "unless-stopped"}
+	args := []string{"run"}
+
+	if service.Container != nil && service.Container.RunOnce {
+		args = append(args, "--rm")
+	} else {
+		args = append(args, "--detach")
+	}
+
+	args = append(args, []string{"--name", container, "--network", project, "--network-alias", service.Name + suffix, "--restart", "unless-stopped"}...)
 
 	for _, value := range service.Env {
 		args = append(args, "-e", value)

diff --git a/pkg/deployment/service.go b/pkg/deployment/service.go
@@ -99,7 +99,7 @@ func (d *Deployment) installService(project string, service *config.Service) err
 		return fmt.Errorf("install failed for %s: container is unhealthy: %w", container, err)
 	}
 
-	err := d.processPreHooks(service, container)
+	err := d.processPreHooks(project, service)
 	if err != nil {
 		return err
 	}
@@ -133,7 +133,7 @@ func (d *Deployment) updateService(project string, service *config.Service) erro
 		return fmt.Errorf("update failed for %s: new container is unhealthy: %w", container, err)
 	}
 
-	err := d.processPreHooks(service, container+newContainerSuffix)
+	err := d.processPreHooks(project, service)
 	if err != nil {
 		return err
 	}
@@ -155,7 +155,7 @@ func (d *Deployment) updateService(project string, service *config.Service) erro
 	return nil
 }
 
-func (d *Deployment) processPreHooks(service *config.Service, container string) error {
+func (d *Deployment) processPreHooks(project string, service *config.Service) error {
 	if service.Hooks == nil || service.Hooks.Pre == nil {
 		return nil
 	}
@@ -165,7 +165,23 @@ func (d *Deployment) processPreHooks(service *config.Service, container string)
 			return fmt.Errorf("local pre-hook failed: %w", err)
 		}
 	}
+
 	if service.Hooks.Pre.Remote != "" {
+		runService := &config.Service{
+			Name:       service.Name,
+			Image:      service.Image,
+			Volumes:    service.Volumes,
+			Env:        service.Env,
+			Entrypoint: service.Entrypoint,
+			Command:    service.Hooks.Pre.Remote,
+			Container:  &config.Container{RunOnce: true},
+		}
+		err := d.createContainer(project, runService, "run")
+		if err != nil {
+			return err
+		}
+
+		container := containerName(project, service.Name, "run")
 		if err := d.runRemoteHook(context.Background(), container, service.Hooks.Pre.Remote); err != nil {
 			return fmt.Errorf("remote pre-hook failed: %w", err)
 		}