Skip to content

Commit

Permalink
[NBS] Increase logging verbosity: include group ID in (Read|Write)Blo…
Browse files Browse the repository at this point in the history
…b logs
  • Loading branch information
ya-ksgamora committed Jan 30, 2025
1 parent 770a655 commit 8ba3a79
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,10 @@ void TPartitionActor::HandleReadBlobCompleted(
>= Config->GetMaxReadBlobErrorsBeforeSuicide())
{
LOG_WARN(ctx, TBlockStoreComponents::PARTITION,
"[%lu] Stop tablet because of too many ReadBlob errors: %s",
"[%lu] Stop tablet because of too many ReadBlob errors (actor %s, group %u): %s",
TabletID(),
ev->Sender.ToString().c_str(),
msg->GroupId,
FormatError(msg->GetError()).data());

ReportTabletBSFailure();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,10 @@ void TPartitionActor::HandleWriteBlobCompleted(

if (FAILED(msg->GetStatus())) {
LOG_WARN(ctx, TBlockStoreComponents::PARTITION,
"[%lu] Stop tablet because of WriteBlob error: %s",
"[%lu] Stop tablet because of WriteBlob error (actor %s, group %u): %s",
TabletID(),
ev->Sender.ToString().c_str(),
groupId,
FormatError(msg->GetError()).data());

ReportTabletBSFailure();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -429,8 +429,10 @@ void TPartitionActor::HandleReadBlobCompleted(
>= Config->GetMaxReadBlobErrorsBeforeSuicide())
{
LOG_WARN(ctx, TBlockStoreComponents::PARTITION,
"[%lu] Stop tablet because of too many ReadBlob errors: %s",
"[%lu] Stop tablet because of too many ReadBlob errors (actor %s, group %u): %s",
TabletID(),
ev->Sender.ToString().c_str(),
msg->GroupId,
FormatError(msg->GetError()).data());

ReportTabletBSFailure();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,10 @@ void TPartitionActor::HandleWriteBlobCompleted(

if (FAILED(msg->GetStatus())) {
LOG_WARN(ctx, TBlockStoreComponents::PARTITION,
"[%lu] Stop tablet because of WriteBlob error: %s",
"[%lu] Stop tablet because of WriteBlob error (actor %s, group %u): %s",
TabletID(),
ev->Sender.ToString().c_str(),
group,
FormatError(msg->GetError()).data());

ReportTabletBSFailure();
Expand Down

0 comments on commit 8ba3a79

Please sign in to comment.