Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSI] Change volume ownership if root directory permissions mismatch #2879

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[CSI] Change volume ownership if root directory permissions mismatch #2879

wants to merge 3 commits into from

Conversation

antonmyagkov
Copy link
Collaborator

@antonmyagkov antonmyagkov commented Jan 17, 2025 •
edited
Loading

issue: #2931

  1. Use SetVolumeOwnership function from Kubernetes: https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/volume_linux.go
  2. Set volume ownership recursively only if root directory permissions mismatch as we want to speedup NodeVolumePublish for large filesystems

@antonmyagkov antonmyagkov changed the title [CSI] Change volume ownership if root directory permirssions mistmatch [CSI] Change volume ownership if root directory permissions mistmatch Jan 17, 2025
@antonmyagkov antonmyagkov changed the title [CSI] Change volume ownership if root directory permissions mistmatch [CSI] Change volume ownership if root directory permissions mismatch Jan 17, 2025
@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch from 91702ba to bd814d7 Compare January 17, 2025 16:36
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit bd814d7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6338 6335 0 3 0 0

@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch 2 times, most recently from 5ae5bb4 to 3142e15 Compare January 19, 2025 12:29
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 3142e15.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6339 6334 0 2 3 0

@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch from 3142e15 to 4ccec5e Compare January 27, 2025 12:57
@antonmyagkov antonmyagkov marked this pull request as ready for review January 27, 2025 13:00
@antonmyagkov antonmyagkov added the blockstore Add this label to run only cloud/blockstore build and tests on PR label Jan 27, 2025
@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch from 4ccec5e to 1edf197 Compare January 27, 2025 13:41
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 1edf197.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3594 3593 0 1 0 0

@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch from 1edf197 to dc10500 Compare January 27, 2025 14:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit dc10500.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3594 3593 0 1 0 0

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit dc10500.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3594 3594 0 0 0 0

@antonmyagkov antonmyagkov requested a review from tpashkin January 27, 2025 16:42
@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch from dc10500 to 14d8a21 Compare January 28, 2025 10:00
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 14d8a21.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3594 3591 0 3 0 0

@antonmyagkov antonmyagkov mentioned this pull request Jan 28, 2025
Merged
tpashkin
tpashkin previously approved these changes Jan 28, 2025
View reviewed changes
@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch from 14d8a21 to 60ca5a7 Compare January 28, 2025 13:02
@antonmyagkov antonmyagkov force-pushed the users/myagkov/csi-driver-set-ownership-on-root-mismatch branch from 60ca5a7 to c159d99 Compare January 28, 2025 13:05
tpashkin
tpashkin previously approved these changes Jan 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit c159d99.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3603 0 1 0 0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 154332e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3603 0 1 0 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 154332e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3603 0 1 0 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 154332e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3603 0 1 0 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 154332e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3602 0 2 0 0

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 154332e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3604 3603 0 1 0 0

@antonmyagkov antonmyagkov added the rebase Add this label if you want to rebase your PR for test run label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 154332e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3610 3610 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpashkin tpashkin tpashkin approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR rebase Add this label if you want to rebase your PR for test run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonmyagkov @tpashkin