Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-2404: don't start migration if it is already finished #2890

Merged
merged 7 commits into from
Jan 30, 2025
Merged

issue-2404: don't start migration if it is already finished #2890

merged 7 commits into from
Jan 30, 2025

Conversation

vladstepanyuk
Copy link
Contributor

@vladstepanyuk vladstepanyuk commented Jan 21, 2025 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@komarevtsev-d komarevtsev-d added blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR ok-to-test Label to approve test launch for external members labels Jan 21, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 21, 2025
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 21, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 21, 2025
komarevtsev-d
komarevtsev-d requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@komarevtsev-d komarevtsev-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ну и юнит тест нужен в disk_registry_state_ut_migration.cpp

cloud/blockstore/libs/storage/disk_registry/disk_registry_database.h Outdated Show resolved Hide resolved
cloud/blockstore/libs/storage/disk_registry/disk_registry_state.cpp Show resolved Hide resolved
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 21, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 717b2a2.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3778 3774 0 4 0 0

@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 22, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 85d58fa.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3781 3780 0 1 0 0

@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 23, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 45e32d8.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3781 3780 0 1 0 0

komarevtsev-d
komarevtsev-d previously approved these changes Jan 28, 2025
View reviewed changes
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Jan 29, 2025
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 5265243.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3781 3781 0 0 0 0

@komarevtsev-d komarevtsev-d merged commit 4510ec7 into ydb-platform:main Jan 30, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komarevtsev-d komarevtsev-d komarevtsev-d approved these changes

@sharpeye sharpeye sharpeye approved these changes

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladstepanyuk @sharpeye @komarevtsev-d