issue-2722: add ability to read from certain replica of mirrored disk #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilyTiger
force-pushed
the
users/wilytiger/issue-2722-3
branch
from
eb6020e to
b0eafc5
Compare
sharpeye
reviewed
Feb 3, 2025
cloud/blockstore/libs/storage/partition_nonrepl/part_mirror_actor_readblocks.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/partition_nonrepl/part_mirror_actor_readblocks.cpp
Outdated
Show resolved
Hide resolved
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 77fd356.
🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 77fd356.
|
sharpeye
reviewed
Feb 5, 2025
cloud/blockstore/libs/storage/partition_nonrepl/part_mirror_actor_readblocks.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/partition_nonrepl/part_mirror_actor_readblocks.cpp
Outdated
Show resolved
Hide resolved
cloud/blockstore/libs/storage/partition_nonrepl/part_mirror_actor.h
Outdated
Show resolved
Hide resolved
sharpeye
reviewed
Feb 6, 2025
cloud/blockstore/libs/storage/partition_nonrepl/part_mirror_actor_readblocks.cpp
Outdated
Show resolved
Hide resolved
sharpeye
previously approved these changes
Feb 6, 2025
drbasic
reviewed
Feb 7, 2025
sharpeye
approved these changes
Feb 7, 2025
drbasic
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provide better diagnostics for checksum mismatches in replicas, I want to add the ability for blockstore-client to read certain replica and compare it further in scripts