feat: add connect to DB dialog #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
1367-db-connection-snippets
branch
2 times, most recently
from
209df57 to
2243d04
Compare
artemmufazalov
commented
Jan 24, 2025
Comment on lines
+164
to
+173
| const copyItem: ActionsSet[0] = { | ||
| text: i18n('actions.copyPath'), | ||
| action: actions.copyPath, | ||
| iconEnd: <Copy />, | ||
| }; | ||
| const connectToDBItem = { | ||
| text: i18n('actions.connectToDB'), | ||
| action: actions.getConnectToDBDialog, | ||
| iconEnd: <PlugConnection />, | ||
| }; |
artemmufazalov
commented
Jan 24, 2025
Comment on lines
+55
to
+57
| const rootNodeType = isDomain(rootPath, rootType) | ||
| ? 'database' | ||
| : mapPathTypeToNavigationTreeType(rootType); |
There was a problem hiding this comment.
Treat domain as database to show how to connect dialog for it
artemmufazalov
commented
Jan 24, 2025
Comment on lines
+38
to
+40
| <ComponentsProvider registry={componentsRegistry}> | ||
| <NiceModal.Provider>{children}</NiceModal.Provider> | ||
| </ComponentsProvider> |
There was a problem hiding this comment.
Components from ComponentsProvider weren't available inside NiceModal
artemmufazalov
force-pushed
the
1367-db-connection-snippets
branch
from
2243d04 to
41b4141
Compare
artemmufazalov
commented
Jan 24, 2025
Comment on lines
+19
to
+20
| top: 13px; | ||
| right: 14px; |
There was a problem hiding this comment.
top and right to match with code area of syntax highlighter
artemmufazalov
commented
Jan 24, 2025
Comment on lines
+34
to
+58
| const darkTheme: Record<string, React.CSSProperties> = { | ||
| ...dark, | ||
| 'pre[class*="language-"]': { | ||
| ...dark['pre[class*="language-"]'], | ||
| background: vscDarkPlus['pre[class*="language-"]'].background, | ||
| scrollbarColor: `var(--g-color-scroll-handle) transparent`, | ||
| }, | ||
| 'code[class*="language-"]': { | ||
| ...dark['code[class*="language-"]'], | ||
| whiteSpace: 'pre', | ||
| }, | ||
| }; | ||
|
|
||
| const lightTheme: Record<string, React.CSSProperties> = { | ||
| ...light, | ||
| 'pre[class*="language-"]': { | ||
| ...light['pre[class*="language-"]'], | ||
| background: 'var(--g-color-base-misc-light)', | ||
| scrollbarColor: `var(--g-color-scroll-handle) transparent`, | ||
| }, | ||
| 'code[class*="language-"]': { | ||
| ...light['code[class*="language-"]'], | ||
| whiteSpace: 'pre', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Use the same style as for the YQL snippets but with some exceptions
artemmufazalov
force-pushed
the
1367-db-connection-snippets
branch
from
41b4141 to
16f9fb5
Compare
artemmufazalov
force-pushed
the
1367-db-connection-snippets
branch
from
16f9fb5 to
568c360
Compare
artemmufazalov
commented
Jan 24, 2025
| SyntaxHighlighter.registerLanguage('php', php); | ||
| SyntaxHighlighter.registerLanguage('python', python); | ||
|
|
||
| type ConnectToDBSyntaxHighlighterProps = { |
There was a problem hiding this comment.
With interface there is TS error Exported variable 'ConnectToDBSyntaxHighlighterLazy' has or is using name 'ConnectToDBSyntaxHighlighterProps' from external module
Raubzeug
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1367, closes #1839
Test stand: https://nda.ya.ru/t/rHe1yYZK7BPzpK
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: 🔺
Current: 80.18 MB | Main: 80.06 MB
Diff: +0.12 MB (0.15%)
ℹ️ CI Information