Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete icons sprite, use gravity icons #853

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

artemmufazalov
Copy link
Member

  1. In many places we used icons from sprite. It's not very handy
  2. Since we used our own icons, they may differ from the icons in components from uikit, thus we may have several versions of the same icon on one page

Deleted sprite, replaced most of the icons with uikit versions

Test stand: https://nda.ya.ru/t/lQGqdSKK768yCA

@@ -0,0 +1,4 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added svgs that was in AppIcons

@artemmufazalov artemmufazalov marked this pull request as ready for review May 28, 2024 15:25
@Raubzeug
Copy link
Contributor

Let's also use this library for illustrations? https://github.com/gravity-ui/illustrations

@artemmufazalov
Copy link
Member Author

Let's also use this library for illustrations? https://github.com/gravity-ui/illustrations

I checked it and I'm not ready to use it yet. It has hardcoded colors in some places, without proper themisation this images don't fit (they're orange, our theme is blue)

I created issue for this: gravity-ui/illustrations#4

Screenshot 2024-05-29 at 12 36 56

@artemmufazalov artemmufazalov merged commit be1d6c3 into main May 29, 2024
4 checks passed
@artemmufazalov artemmufazalov deleted the update-icons branch May 29, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants