Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic transactions #243

Merged
merged 30 commits into from
Mar 25, 2024
Merged

Topic transactions #243

merged 30 commits into from
Mar 25, 2024

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Mar 21, 2024

No description provided.

@pnv1 pnv1 added the enhancement New feature or request label Mar 21, 2024
@pnv1 pnv1 requested a review from alex268 March 21, 2024 08:17
@pnv1 pnv1 self-assigned this Mar 21, 2024
@pnv1 pnv1 linked an issue Mar 21, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 9.60452% with 320 lines in your changes are missing coverage. Please review.

Project coverage is 41.00%. Comparing base (d33eeab) to head (0fd33a2).

Files Patch % Lines
...src/main/java/tech/ydb/table/impl/BaseSession.java 2.85% 68 Missing ⚠️
...main/java/tech/ydb/topic/read/impl/ReaderImpl.java 0.00% 60 Missing ⚠️
...c/read/impl/TransactionMessageAccumulatorImpl.java 0.00% 42 Missing ⚠️
...c/main/java/tech/ydb/table/impl/TxControlToPb.java 0.00% 34 Missing ⚠️
.../java/tech/ydb/topic/settings/ReceiveSettings.java 0.00% 18 Missing ⚠️
...src/main/java/tech/ydb/query/impl/SessionImpl.java 68.08% 8 Missing and 7 partials ⚠️
.../java/tech/ydb/topic/read/impl/SyncReaderImpl.java 0.00% 12 Missing ⚠️
...ain/java/tech/ydb/topic/settings/SendSettings.java 0.00% 11 Missing ⚠️
.../java/tech/ydb/topic/write/impl/MessageSender.java 0.00% 8 Missing ⚠️
...a/tech/ydb/table/transaction/TableTransaction.java 0.00% 6 Missing ⚠️
... and 16 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #243      +/-   ##
=============================================
- Coverage      41.99%   41.00%   -0.99%     
+ Complexity      1409     1408       -1     
=============================================
  Files            282      289       +7     
  Lines          10912    11201     +289     
  Branches        1073     1101      +28     
=============================================
+ Hits            4582     4593      +11     
- Misses          5970     6246     +276     
- Partials         360      362       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 merged commit 0b47bb5 into develop Mar 25, 2024
7 checks passed
@pnv1 pnv1 deleted the topic_transactions branch March 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants