Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging improvements for topic reader & writer #359

Merged
merged 5 commits into from
Jan 23, 2025
Merged

Conversation

pnv1
Copy link
Collaborator

@pnv1 pnv1 commented Jan 23, 2025

Example:
[9ka8R7.1/2-p8] Received StartPartitionSessionRequest for Topic "ydb-test/test-topic" and Consumer "/ydb-test/test-consumer". Partition session 2 (partition 8) with committedOffset 173587 and partitionOffsets [173587-173587)
9ka8R7: reader generated random id
1: stream id (increments with each reconnect)
2: Partition session id. Set by server
p8: partition id (8)

@pnv1 pnv1 requested a review from alex268 January 23, 2025 13:14
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 57.60870% with 39 lines in your changes missing coverage. Please review.

Project coverage is 57.72%. Comparing base (4271d4a) to head (b169df1).

Files with missing lines Patch % Lines
...tech/ydb/topic/read/impl/PartitionSessionImpl.java 51.85% 26 Missing ⚠️
...main/java/tech/ydb/topic/read/impl/ReaderImpl.java 57.89% 8 Missing ⚠️
...ech/ydb/topic/read/impl/DeferredCommitterImpl.java 0.00% 3 Missing ⚠️
...n/java/tech/ydb/topic/read/impl/CommitterImpl.java 50.00% 0 Missing and 1 partial ⚠️
...ain/java/tech/ydb/topic/write/impl/WriterImpl.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #359      +/-   ##
============================================
+ Coverage     57.65%   57.72%   +0.07%     
  Complexity     2055     2055              
============================================
  Files           311      311              
  Lines         12548    12550       +2     
  Branches       1245     1245              
============================================
+ Hits           7235     7245      +10     
+ Misses         4720     4712       -8     
  Partials        593      593              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnv1 pnv1 merged commit 28bee3a into master Jan 23, 2025
8 checks passed
@pnv1 pnv1 deleted the logging-improvements branch January 23, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants