Add upsert support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 9, 2024 13:36
LuckySting
suggested changes
Jan 11, 2024
| @@ -341,13 +342,16 @@ def get_bind_types( | |||
|
|
|||
| return parameter_types | |||
|
|
|||
| def visit_upsert(self, insert_stmt, visited_bindparam=None, **kw): | |||
| return self.visit_insert(insert_stmt, visited_bindparam, **kw).replace("INSERT", "UPSERT") | |||
There was a problem hiding this comment.
issue (blocking) We should not replace all occurrences of "INSERT", because of the unexpected string values content, like:
UPSERT INTO TABLE my_table VALUES('INSERT is my favourite operation')
Also the test of this case should be
| @@ -200,3 +202,49 @@ def test_select_types(self, connection): | |||
|
|
|||
| row = connection.execute(sa.select(tb)).fetchone() | |||
| assert row == (1, "Hello World!", 3.5, True, now, today) | |||
|
|
|||
|
|
|||
| class TestUpsert(TablesTest): | |||
There was a problem hiding this comment.
issue (blocking) Let's add also tests with several UPSERTs and UPSERT FROM SELECT, if it is supported, not sure
LuckySting
approved these changes
Jan 15, 2024
LuckySting
approved these changes
Jan 16, 2024
rekby
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.