fix thread sanitizer alarms (#13522)

ydb-platform · Jan 19, 2025 · 6dae4df · 6dae4df
1 parent a096daa
commit 6dae4df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.cpp b/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.cpp
@@ -79,8 +79,8 @@ TString TFetchingScript::DebugString() const {
         return "";
     }
     sb << "{branch:" << BranchName << ";";
-    if (FinishInstant && StartInstant) {
-        sb << "duration:" << *FinishInstant - *StartInstant << ";";
+    if (AtomicGet(FinishInstant) && AtomicGet(StartInstant)) {
+        sb << "duration:" << AtomicGet(FinishInstant) - AtomicGet(StartInstant) << ";";
     }
 
     sb << "steps_10Ms:[" << sbBranch << "]}";

diff --git a/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.h b/ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetching.h
@@ -109,8 +109,8 @@ class TFetchingScript {
 private:
     YDB_ACCESSOR(TString, BranchName, "UNDEFINED");
     std::vector<std::shared_ptr<IFetchingStep>> Steps;
-    std::optional<TMonotonic> StartInstant;
-    std::optional<TMonotonic> FinishInstant;
+    TAtomic StartInstant;
+    TAtomic FinishInstant;
 
 public:
     TFetchingScript(const TSpecialReadContext& context);
@@ -122,14 +122,12 @@ class TFetchingScript {
     }
 
     void AddStepDuration(const ui32 index, const TDuration d) {
-        FinishInstant = TMonotonic::Now();
+        AtomicSet(FinishInstant, TMonotonic::Now().MicroSeconds());
         GetStep(index)->AddDuration(d);
     }
 
     void OnExecute() {
-        if (!StartInstant) {
-            StartInstant = TMonotonic::Now();
-        }
+        AtomicCas(&StartInstant, TMonotonic::Now().MicroSeconds(), 0);
     }
 
     TString DebugString() const;