export: review fixes

ydb-platform · Jan 24, 2025 · eb25e5a · eb25e5a
1 parent 08862d4
commit eb25e5a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/ydb/core/tx/schemeshard/schemeshard_export__create.cpp b/ydb/core/tx/schemeshard/schemeshard_export__create.cpp
@@ -16,6 +16,16 @@
 #include <util/generic/xrange.h>
 #include <util/string/builder.h>
 
+namespace {
+
+ui32 PopFront(TDeque<ui32>& pendingItems) {
+    const ui32 itemIdx = pendingItems.front();
+    pendingItems.pop_front();
+    return itemIdx;
+}
+
+}
+
 namespace NKikimr {
 namespace NSchemeShard {
 
@@ -684,12 +694,6 @@ struct TSchemeShard::TExport::TTxProgress: public TSchemeShard::TXxport::TTxBase
         }
     }
 
-    ui32 PopFront(TDeque<ui32>& pendingItems) {
-        const ui32 itemIdx = pendingItems.front();
-        pendingItems.pop_front();
-        return itemIdx;
-    }
-
     void EndExport(TExportInfo::TPtr exportInfo, EState finalState, NIceDb::TNiceDb& db) {
         exportInfo->State = finalState;
         exportInfo->EndTime = TAppData::TimeProvider->Now();

diff --git a/ydb/core/tx/schemeshard/schemeshard_export__forget.cpp b/ydb/core/tx/schemeshard/schemeshard_export__forget.cpp
@@ -81,7 +81,6 @@ struct TSchemeShard::TExport::TTxForget: public TSchemeShard::TXxport::TTxBase {
             exportInfo->State = TExportInfo::EState::Dropping;
             Self->PersistExportState(db, exportInfo);
 
-            TVector<ui32> itemsToDrop;
             for (ui32 itemIdx : xrange(exportInfo->Items.size())) {
                 auto& item = exportInfo->Items.at(itemIdx);
 
@@ -91,14 +90,10 @@ struct TSchemeShard::TExport::TTxForget: public TSchemeShard::TXxport::TTxBase {
                 const TPath itemPath = TPath::Resolve(ExportItemPathName(Self, exportInfo, itemIdx), Self);
                 if (itemPath.IsResolved() && !itemPath.IsDeleted()) {
                     item.State = TExportInfo::EState::Dropping;
-                    itemsToDrop.emplace_back(itemIdx);
                 }
 
                 Self->PersistExportItemState(db, exportInfo, itemIdx);
             }
-            LOG_T("TExport::TTxForget, items to drop"
-                << ", items: " << JoinSeq(", ", itemsToDrop)
-            );
 
             Progress = true;
         }