Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default compression via CSConfig #12542

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

vlad-gogov
Copy link
Collaborator

@vlad-gogov vlad-gogov commented Dec 12, 2024

Changelog entry

  • Changed the default compression to ZSTD with a compression level of one.
  • Added the ability to change the default compression through the CS configuration.
  • If compression is not specified for a column in a schema, plain compression will not be specified.
  • Added error checking if compression level is set but compression type is not specified.

Changelog category

  • New feature

@vlad-gogov vlad-gogov self-assigned this Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 06:17:48 UTC Pre-commit check linux-x86_64-release-asan for 47ea561 has started.
2024-12-12 06:18:27 UTC Artifacts will be uploaded here
2024-12-12 06:22:17 UTC ya make is running...
🟡 2024-12-12 07:54:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15298 15236 0 14 4 44

🟢 2024-12-12 07:55:39 UTC Build successful.
🟢 2024-12-12 07:56:01 UTC ydbd size 3.6 GiB changed* by +24.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 22dd11e merge: 47ea561 diff diff %
ydbd size 3 898 431 264 Bytes 3 898 456 424 Bytes +24.6 KiB +0.001%
ydbd stripped size 1 366 673 680 Bytes 1 366 682 000 Bytes +8.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 12, 2024

2024-12-12 06:18:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 47ea561 has started.
2024-12-12 06:19:05 UTC Artifacts will be uploaded here
2024-12-12 06:22:30 UTC ya make is running...
🟡 2024-12-12 07:53:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32797 29871 0 2 2812 112

2024-12-12 07:56:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-12 08:08:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
747 (only retried tests) 639 0 1 0 107

2024-12-12 08:08:42 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-12 08:20:33 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
668 (only retried tests) 560 0 1 0 107

🟢 2024-12-12 08:20:42 UTC Build successful.
🟢 2024-12-12 08:21:02 UTC ydbd size 2.1 GiB changed* by +12.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 22dd11e merge: 47ea561 diff diff %
ydbd size 2 256 167 104 Bytes 2 256 180 160 Bytes +12.8 KiB +0.001%
ydbd stripped size 483 930 096 Bytes 483 931 536 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vlad-gogov vlad-gogov force-pushed the default_compression_in_config branch 2 times, most recently from 944f137 to 1e64839 Compare December 19, 2024 03:46
Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 03:50:10 UTC Pre-commit check linux-x86_64-release-asan for 20db886 has started.
2024-12-19 03:50:20 UTC Artifacts will be uploaded here
2024-12-19 03:53:33 UTC ya make is running...
🟡 2024-12-19 05:27:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14032 13920 0 60 5 47

🟢 2024-12-19 05:29:16 UTC Build successful.
🟢 2024-12-19 05:29:38 UTC ydbd size 3.6 GiB changed* by +6.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3317b75 merge: 20db886 diff diff %
ydbd size 3 895 809 416 Bytes 3 895 815 936 Bytes +6.4 KiB +0.000%
ydbd stripped size 1 364 187 216 Bytes 1 364 188 048 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 03:50:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 20db886 has started.
2024-12-19 03:50:34 UTC Artifacts will be uploaded here
2024-12-19 03:53:48 UTC ya make is running...
🟡 2024-12-19 05:20:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31042 28096 0 1 2830 115

2024-12-19 05:23:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-19 05:35:04 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 51 0 0 0 109

🟢 2024-12-19 05:35:11 UTC Build successful.
🟢 2024-12-19 05:35:29 UTC ydbd size 2.1 GiB changed* by +7.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3317b75 merge: 20db886 diff diff %
ydbd size 2 254 471 696 Bytes 2 254 479 616 Bytes +7.7 KiB +0.000%
ydbd stripped size 483 160 496 Bytes 483 161 008 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vlad-gogov vlad-gogov marked this pull request as ready for review December 19, 2024 07:32
@vlad-gogov vlad-gogov force-pushed the default_compression_in_config branch from 1e64839 to f1e3c60 Compare December 19, 2024 12:02
@vlad-gogov vlad-gogov requested a review from a team as a code owner December 19, 2024 12:02
Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 12:06:04 UTC Pre-commit check linux-x86_64-release-asan for 3f46e73 has started.
2024-12-19 12:06:15 UTC Artifacts will be uploaded here
2024-12-19 12:07:45 UTC Check cancelled

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 12:06:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f46e73 has started.
2024-12-19 12:06:38 UTC Artifacts will be uploaded here
2024-12-19 12:07:45 UTC Check cancelled

@vlad-gogov vlad-gogov force-pushed the default_compression_in_config branch from f1e3c60 to 6ee9696 Compare December 19, 2024 12:07
Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 12:09:13 UTC Pre-commit check linux-x86_64-release-asan for dea31d1 has started.
2024-12-19 12:09:17 UTC Artifacts will be uploaded here
2024-12-19 12:12:26 UTC ya make is running...
🟡 2024-12-19 13:59:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14033 13733 0 229 22 49

🟢 2024-12-19 14:01:08 UTC Build successful.
🟢 2024-12-19 14:01:38 UTC ydbd size 3.6 GiB changed* by +98.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d48cc77 merge: dea31d1 diff diff %
ydbd size 3 865 219 656 Bytes 3 865 320 360 Bytes +98.3 KiB +0.003%
ydbd stripped size 1 350 327 184 Bytes 1 350 342 864 Bytes +15.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 12:09:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for dea31d1 has started.
2024-12-19 12:09:19 UTC Artifacts will be uploaded here
2024-12-19 12:12:49 UTC ya make is running...
🟡 2024-12-19 13:44:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31047 27854 0 245 2833 115

2024-12-19 13:47:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-19 13:59:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
549 (only retried tests) 195 0 244 0 110

2024-12-19 14:00:14 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-19 14:12:37 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
542 (only retried tests) 188 0 244 0 110

🟢 2024-12-19 14:12:50 UTC Build successful.
🟢 2024-12-19 14:13:16 UTC ydbd size 2.1 GiB changed* by +54.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 14c83d5 merge: dea31d1 diff diff %
ydbd size 2 234 561 384 Bytes 2 234 617 040 Bytes +54.4 KiB +0.002%
ydbd stripped size 477 801 392 Bytes 477 802 416 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vlad-gogov vlad-gogov force-pushed the default_compression_in_config branch 2 times, most recently from a1f0a3f to 74572a2 Compare December 20, 2024 06:12
Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 06:15:14 UTC Pre-commit check linux-x86_64-release-asan for da271dc has started.
2024-12-20 06:15:25 UTC Artifacts will be uploaded here
2024-12-20 06:18:35 UTC ya make is running...
2024-12-20 07:37:07 UTC Check cancelled

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 06:15:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for da271dc has started.
2024-12-20 06:15:53 UTC Artifacts will be uploaded here
2024-12-20 06:19:05 UTC ya make is running...
2024-12-20 07:37:10 UTC Check cancelled

@vlad-gogov vlad-gogov requested a review from Enjection December 20, 2024 07:37
Enjection
Enjection previously approved these changes Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 07:38:57 UTC Pre-commit check linux-x86_64-release-asan for cbaa9d1 has started.
2024-12-20 07:39:35 UTC Artifacts will be uploaded here
2024-12-20 07:43:18 UTC ya make is running...
🟡 2024-12-20 08:44:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14044 13829 0 164 4 47

🟢 2024-12-20 08:45:16 UTC Build successful.
🟢 2024-12-20 08:45:40 UTC ydbd size 3.6 GiB changed* by +71.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3f79dce merge: cbaa9d1 diff diff %
ydbd size 3 865 560 136 Bytes 3 865 633 232 Bytes +71.4 KiB +0.002%
ydbd stripped size 1 350 398 032 Bytes 1 350 414 544 Bytes +16.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 07:41:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for cbaa9d1 has started.
2024-12-20 07:41:30 UTC Artifacts will be uploaded here
2024-12-20 07:44:48 UTC ya make is running...
🟡 2024-12-20 08:46:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31067 27875 0 245 2831 116

2024-12-20 08:48:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-20 09:01:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
547 (only retried tests) 193 0 243 0 111

2024-12-20 09:01:32 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-20 09:13:47 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
540 (only retried tests) 186 0 243 0 111

🟢 2024-12-20 09:13:58 UTC Build successful.
🟢 2024-12-20 09:14:26 UTC ydbd size 2.1 GiB changed* by +31.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6ea7dea merge: cbaa9d1 diff diff %
ydbd size 2 234 739 552 Bytes 2 234 771 536 Bytes +31.2 KiB +0.001%
ydbd stripped size 477 819 280 Bytes 477 821 392 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 10:37:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7c88b58 has started.
2024-12-20 10:37:30 UTC Artifacts will be uploaded here
2024-12-20 10:40:44 UTC ya make is running...
🟡 2024-12-20 12:11:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31068 28020 0 103 2832 113

2024-12-20 12:13:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-20 12:18:50 UTC ydbd size 2.1 GiB changed* by +48.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 291222e merge: 7c88b58 diff diff %
ydbd size 2 234 869 408 Bytes 2 234 918 624 Bytes +48.1 KiB +0.002%
ydbd stripped size 477 835 088 Bytes 477 837 072 Bytes +1.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-20 12:18:52 UTC Check cancelled

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 10:37:19 UTC Pre-commit check linux-x86_64-release-asan for 7c88b58 has started.
2024-12-20 10:37:30 UTC Artifacts will be uploaded here
2024-12-20 10:40:40 UTC ya make is running...
🟡 2024-12-20 12:19:04 UTC ydbd size 3.6 GiB changed* by +109.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 291222e merge: 7c88b58 diff diff %
ydbd size 3 865 748 784 Bytes 3 865 861 216 Bytes +109.8 KiB +0.003%
ydbd stripped size 1 350 424 624 Bytes 1 350 441 520 Bytes +16.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-20 12:19:05 UTC Check cancelled

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 12:22:10 UTC Pre-commit check linux-x86_64-release-asan for a5ed3b5 has started.
2024-12-20 12:22:21 UTC Artifacts will be uploaded here
2024-12-20 12:25:46 UTC ya make is running...
🟡 2024-12-20 14:10:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14056 13979 0 24 6 47

🟢 2024-12-20 14:11:34 UTC Build successful.
🟡 2024-12-20 14:11:58 UTC ydbd size 3.6 GiB changed* by +109.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b375d19 merge: a5ed3b5 diff diff %
ydbd size 3 866 106 856 Bytes 3 866 219 120 Bytes +109.6 KiB +0.003%
ydbd stripped size 1 350 473 360 Bytes 1 350 494 416 Bytes +20.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 08:31:28 UTC Pre-commit check linux-x86_64-release-asan for 7494cad has started.
2025-01-15 08:31:40 UTC Artifacts will be uploaded here
2025-01-15 08:34:48 UTC ya make is running...
🟡 2025-01-15 09:40:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12109 12055 0 18 9 27

2025-01-15 09:41:10 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 10:01:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
86 (only retried tests) 55 0 4 1 26

2025-01-15 10:01:14 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-15 10:13:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 25 0 3 0 26

🟢 2025-01-15 10:13:39 UTC Build successful.
🟢 2025-01-15 10:14:13 UTC ydbd size 3.6 GiB changed* by +66.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b7192f6 merge: 7494cad diff diff %
ydbd size 3 895 388 520 Bytes 3 895 456 544 Bytes +66.4 KiB +0.002%
ydbd stripped size 1 360 960 784 Bytes 1 360 965 136 Bytes +4.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 12:08:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for f21093e has started.
2025-01-15 12:08:52 UTC Artifacts will be uploaded here
2025-01-15 12:12:01 UTC ya make is running...
🟡 2025-01-15 13:38:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27392 24879 0 7 2380 126

2025-01-15 13:40:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 13:53:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 71 0 2 0 118

2025-01-15 13:53:12 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-15 14:06:10 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 57 0 1 0 116

🟢 2025-01-15 14:06:18 UTC Build successful.
🟢 2025-01-15 14:06:42 UTC ydbd size 2.1 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4959d3e merge: f21093e diff diff %
ydbd size 2 247 494 784 Bytes 2 247 508 392 Bytes +13.3 KiB +0.001%
ydbd stripped size 472 865 744 Bytes 472 857 104 Bytes -8.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 15, 2025

2025-01-15 12:08:50 UTC Pre-commit check linux-x86_64-release-asan for f21093e has started.
2025-01-15 12:09:03 UTC Artifacts will be uploaded here
2025-01-15 12:12:12 UTC ya make is running...
🟡 2025-01-15 13:51:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13451 13383 0 26 15 27

2025-01-15 13:52:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-15 14:05:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
111 (only retried tests) 84 0 1 0 26

2025-01-15 14:05:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-15 14:17:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
49 (only retried tests) 23 0 1 1 24

🟢 2025-01-15 14:17:30 UTC Build successful.
🟢 2025-01-15 14:18:00 UTC ydbd size 3.6 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4959d3e merge: f21093e diff diff %
ydbd size 3 895 426 488 Bytes 3 895 440 120 Bytes +13.3 KiB +0.000%
ydbd stripped size 1 360 971 952 Bytes 1 360 934 704 Bytes -36.4 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

swalrus1
swalrus1 previously approved these changes Jan 15, 2025
Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 04:13:49 UTC Pre-commit check linux-x86_64-release-asan for c02ce22 has started.
2025-01-16 04:14:01 UTC Artifacts will be uploaded here
2025-01-16 04:17:21 UTC ya make is running...
🟡 2025-01-16 05:47:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13469 13417 0 18 9 25

2025-01-16 05:57:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-16 06:10:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
83 (only retried tests) 52 0 2 6 23

2025-01-16 06:10:12 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-16 06:18:44 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
54 (only retried tests) 31 0 0 0 23

🟢 2025-01-16 06:18:51 UTC Build successful.
🟢 2025-01-16 06:19:19 UTC ydbd size 3.6 GiB changed* by +5.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f322990 merge: c02ce22 diff diff %
ydbd size 3 903 154 728 Bytes 3 903 160 144 Bytes +5.3 KiB +0.000%
ydbd stripped size 1 362 764 208 Bytes 1 362 718 704 Bytes -44.4 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 16, 2025

2025-01-16 04:14:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for c02ce22 has started.
2025-01-16 04:14:22 UTC Artifacts will be uploaded here
2025-01-16 04:17:41 UTC ya make is running...
🟡 2025-01-16 05:41:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27426 24921 0 1 2380 124

2025-01-16 05:58:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-16 06:09:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 61 0 0 0 121

🟢 2025-01-16 06:10:02 UTC Build successful.
🟢 2025-01-16 06:10:23 UTC ydbd size 2.1 GiB changed* by +13.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f322990 merge: c02ce22 diff diff %
ydbd size 2 252 661 744 Bytes 2 252 675 360 Bytes +13.3 KiB +0.001%
ydbd stripped size 473 496 144 Bytes 473 487 504 Bytes -8.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vlad-gogov vlad-gogov requested a review from zverevgeny January 16, 2025 12:10
ydb/core/tx/schemeshard/olap/column_families/update.h Outdated Show resolved Hide resolved
ydb/core/kqp/ut/common/columnshard.h Outdated Show resolved Hide resolved
ydb/core/formats/arrow/serializer/utils.h Outdated Show resolved Hide resolved
ydb/core/base/appdata_fwd.h Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 05:25:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 094bf46 has started.
2025-01-17 05:25:09 UTC Artifacts will be uploaded here
2025-01-17 05:28:22 UTC ya make is running...
🔴 2025-01-17 07:18:01 UTC Too many tests failed, NOT going to retry
🔴 2025-01-17 07:26:18 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26580 17821 0 5821 2719 219

🟢 2025-01-17 07:28:41 UTC Build successful.
🟢 2025-01-17 07:29:16 UTC ydbd size 2.1 GiB changed* by +69.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 32f057a merge: 094bf46 diff diff %
ydbd size 2 252 364 992 Bytes 2 252 436 048 Bytes +69.4 KiB +0.003%
ydbd stripped size 473 385 872 Bytes 473 392 496 Bytes +6.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 05:25:56 UTC Pre-commit check linux-x86_64-release-asan for 094bf46 has started.
2025-01-17 05:26:08 UTC Artifacts will be uploaded here
2025-01-17 05:29:27 UTC ya make is running...
🔴 2025-01-17 07:02:25 UTC Too many tests failed, NOT going to retry
🟡 2025-01-17 07:04:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13164 11907 0 1099 124 34

🟢 2025-01-17 07:05:35 UTC Build successful.
🟡 2025-01-17 07:06:10 UTC ydbd size 3.6 GiB changed* by +335.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 32f057a merge: 094bf46 diff diff %
ydbd size 3 902 686 176 Bytes 3 903 029 800 Bytes +335.6 KiB +0.009%
ydbd stripped size 1 362 502 000 Bytes 1 362 579 184 Bytes +75.4 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 07:48:27 UTC Pre-commit check linux-x86_64-release-asan for 3b65460 has started.
2025-01-17 07:48:32 UTC Artifacts will be uploaded here
2025-01-17 07:51:48 UTC ya make is running...
🟡 2025-01-17 09:18:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13177 12943 0 181 26 27

2025-01-17 09:19:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-17 09:37:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
419 (only retried tests) 210 0 161 23 25

2025-01-17 09:37:22 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-17 09:49:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
384 (only retried tests) 175 0 161 23 25

🟢 2025-01-17 09:49:47 UTC Build successful.
🟡 2025-01-17 09:50:21 UTC ydbd size 3.6 GiB changed* by +335.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 32f057a merge: 3b65460 diff diff %
ydbd size 3 902 686 176 Bytes 3 903 029 656 Bytes +335.4 KiB +0.009%
ydbd stripped size 1 362 502 000 Bytes 1 362 579 184 Bytes +75.4 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 07:48:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3b65460 has started.
2025-01-17 07:48:58 UTC Artifacts will be uploaded here
2025-01-17 07:52:23 UTC ya make is running...
🟡 2025-01-17 09:20:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27435 24412 0 478 2420 125

2025-01-17 09:23:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-17 09:37:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
998 (only retried tests) 360 0 481 38 119

2025-01-17 09:38:17 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-17 09:52:25 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
989 (only retried tests) 349 0 483 38 119

🟢 2025-01-17 09:52:37 UTC Build successful.
🟢 2025-01-17 09:53:07 UTC ydbd size 2.1 GiB changed* by +69.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 32f057a merge: 3b65460 diff diff %
ydbd size 2 252 364 992 Bytes 2 252 436 048 Bytes +69.4 KiB +0.003%
ydbd stripped size 473 385 872 Bytes 473 392 496 Bytes +6.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vlad-gogov vlad-gogov force-pushed the default_compression_in_config branch from 5f0c661 to 06990a6 Compare January 17, 2025 11:01
Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 11:04:13 UTC Pre-commit check linux-x86_64-release-asan for 55d3774 has started.
2025-01-17 11:04:18 UTC Artifacts will be uploaded here
2025-01-17 11:07:26 UTC ya make is running...
🟡 2025-01-17 12:37:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13258 13203 0 22 6 27

2025-01-17 12:38:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-17 12:52:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
88 (only retried tests) 60 0 0 4 24

🟢 2025-01-17 12:52:15 UTC Build successful.
🟢 2025-01-17 12:52:41 UTC ydbd size 3.6 GiB changed* by +9.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3712773 merge: 55d3774 diff diff %
ydbd size 3 903 186 552 Bytes 3 903 196 184 Bytes +9.4 KiB +0.000%
ydbd stripped size 1 362 669 904 Bytes 1 362 628 368 Bytes -40.6 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 17, 2025

2025-01-17 11:04:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 55d3774 has started.
2025-01-17 11:05:10 UTC Artifacts will be uploaded here
2025-01-17 11:08:27 UTC ya make is running...
🟡 2025-01-17 12:31:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27492 24988 0 2 2380 122

2025-01-17 12:33:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-17 12:45:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
179 (only retried tests) 62 0 0 0 117

🟢 2025-01-17 12:45:54 UTC Build successful.
🟢 2025-01-17 12:46:14 UTC ydbd size 2.1 GiB changed* by +9.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3712773 merge: 55d3774 diff diff %
ydbd size 2 252 515 384 Bytes 2 252 525 056 Bytes +9.4 KiB +0.000%
ydbd stripped size 473 418 704 Bytes 473 405 968 Bytes -12.4 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

ydb/core/base/appdata_fwd.h Show resolved Hide resolved
ydb/core/base/appdata_fwd.h Show resolved Hide resolved
ydb/core/base/appdata_fwd.h Show resolved Hide resolved
@@ -20,6 +23,10 @@ class TNativeSerializer: public ISerializer {
private:
arrow::ipc::IpcWriteOptions Options;

static inline std::shared_ptr<arrow::util::Codec> DefaultCodec() {
return NArrow::TStatusValidator::GetValid(arrow::util::Codec::Create(arrow::Compression::type::ZSTD, 1));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZSTD/1 это что?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сжатие по умолчанию, если его не задали в конфигурации CS

ydb/core/formats/arrow/serializer/native.cpp Outdated Show resolved Hide resolved
ydb/core/formats/arrow/serializer/native.h Show resolved Hide resolved
ydb/core/formats/arrow/serializer/native.h Outdated Show resolved Hide resolved
ydb/core/formats/arrow/serializer/native.h Show resolved Hide resolved
ydb/core/formats/arrow/serializer/utils.cpp Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 09:59:19 UTC Pre-commit check linux-x86_64-release-asan for 6a73c0c has started.
2025-01-23 09:59:31 UTC Artifacts will be uploaded here
2025-01-23 10:02:41 UTC ya make is running...
🟡 2025-01-23 11:32:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13139 13067 0 26 14 32

🟢 2025-01-23 11:34:24 UTC ydbd size 3.6 GiB changed* by +5.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78fee80 merge: 6a73c0c diff diff %
ydbd size 3 858 261 672 Bytes 3 858 266 816 Bytes +5.0 KiB +0.000%
ydbd stripped size 1 349 573 328 Bytes 1 349 528 336 Bytes -43.9 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-23 11:34:26 UTC Check cancelled

Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 10:01:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6a73c0c has started.
2025-01-23 10:01:57 UTC Artifacts will be uploaded here
2025-01-23 10:05:10 UTC ya make is running...
🟡 2025-01-23 11:32:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27432 24901 0 4 2397 130

🟢 2025-01-23 11:34:22 UTC ydbd size 2.1 GiB changed* by +19.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78fee80 merge: 6a73c0c diff diff %
ydbd size 2 220 428 304 Bytes 2 220 448 280 Bytes +19.5 KiB +0.001%
ydbd stripped size 469 670 576 Bytes 469 662 256 Bytes -8.1 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-23 11:34:25 UTC Check cancelled

ydb/core/formats/arrow/serializer/native.h Show resolved Hide resolved
@@ -50,10 +53,30 @@ class TNativeSerializer: public ISerializer {

virtual TConclusionStatus DoDeserializeFromRequest(NYql::TFeaturesExtractor& features) override;

static arrow::Compression::type GetDefaultCompressionType() {
if (!HasAppData() && !AppData()->ColumnShardConfig.HasDefaultCompression()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поправь условие.
LZ4 по умолчанию

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вернул LZ4 по умолчанию и поправил условию.

Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 11:38:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9afb90e has started.
2025-01-23 11:38:39 UTC Artifacts will be uploaded here
2025-01-23 11:41:49 UTC ya make is running...
🟡 2025-01-23 12:34:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27432 24900 0 9 2399 124

2025-01-23 12:36:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 12:47:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 73 0 1 0 120

2025-01-23 12:47:21 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-23 12:56:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 60 0 0 0 116

🟢 2025-01-23 12:56:44 UTC Build successful.
🟢 2025-01-23 12:57:07 UTC ydbd size 2.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bd79c91 merge: 9afb90e diff diff %
ydbd size 2 220 428 304 Bytes 2 220 449 176 Bytes +20.4 KiB +0.001%
ydbd stripped size 469 670 576 Bytes 469 661 936 Bytes -8.4 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 11:39:04 UTC Pre-commit check linux-x86_64-release-asan for 9afb90e has started.
2025-01-23 11:39:17 UTC Artifacts will be uploaded here
2025-01-23 11:42:39 UTC ya make is running...
🟡 2025-01-23 12:46:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13139 13066 0 32 12 29

2025-01-23 12:47:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 12:59:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 77 0 2 2 25

2025-01-23 12:59:45 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-23 13:11:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
51 (only retried tests) 23 0 2 3 23

🟢 2025-01-23 13:11:26 UTC Build successful.
🟢 2025-01-23 13:11:55 UTC ydbd size 3.6 GiB changed* by +17.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bd79c91 merge: 9afb90e diff diff %
ydbd size 3 858 261 672 Bytes 3 858 279 056 Bytes +17.0 KiB +0.000%
ydbd stripped size 1 349 573 328 Bytes 1 349 528 336 Bytes -43.9 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default compression via CS config
6 participants