Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQ-3970 RD fixed memory leak in filters #12756

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Dec 19, 2024

Changelog entry

Fixed memory leak in filters

Changelog category

  • Bugfix

Additional information

grigoriypisar and others added 2 commits December 19, 2024 07:19
Fixed purecalc cache invalidation
commit_hash:088ac16b3481db39893f4fab0cf80c3809a5dcdd
@GrigoriyPA GrigoriyPA requested review from a team as code owners December 19, 2024 07:20
Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 07:21:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for a422b70 has started.
2024-12-19 07:21:57 UTC Artifacts will be uploaded here
2024-12-19 07:25:19 UTC ya make is running...
🟡 2024-12-19 08:42:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32889 30055 0 4 2719 111

2024-12-19 08:46:01 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-19 08:59:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
719 (only retried tests) 612 0 0 0 107

🟢 2024-12-19 08:59:25 UTC Build successful.

Copy link

github-actions bot commented Dec 19, 2024

2024-12-19 07:21:46 UTC Pre-commit check linux-x86_64-release-asan for a422b70 has started.
2024-12-19 07:21:58 UTC Artifacts will be uploaded here
2024-12-19 07:25:11 UTC ya make is running...
🟡 2024-12-19 08:50:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15511 15442 0 14 7 48

🟢 2024-12-19 08:52:28 UTC Build successful.

@@ -77,6 +77,7 @@ struct TComputationMutables {
std::vector<ui32> SerializableValues; // Indices of values that need to be saved in IComputationGraph::SaveGraphState() and restored in IComputationGraph::LoadGraphState().
ui32 CurWideFieldsIndex = 0U;
std::vector<TWideFieldsInitInfo> WideFieldInitialize;
std::vector<ui32> CachedValues; // Indices of values that holds temporary cached data and unreachable by dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Правки в /yql/essentials надо вносить в аркадию сначала

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и /yt тоже

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сорри, это ваш бранч, делайте что хотите:)

Предлагаю поправить CODEOWNERS чтобы не было ревьюеров обычных

@GrigoriyPA GrigoriyPA merged commit 4dd4793 into ydb-platform:q-stable-2024-12-05 Dec 19, 2024
10 checks passed
@GrigoriyPA GrigoriyPA deleted the merge-to-yq-stable-YQ-3970-fix-memory-leak-in-filters branch December 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants