Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for Digest #12889

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Update docs for Digest #12889

merged 5 commits into from
Jan 13, 2025

Conversation

avevad
Copy link
Member

@avevad avevad commented Dec 23, 2024

Changelog entry

...

Changelog category

  • Documentation (changelog entry is not required)

Additional information

...

@avevad avevad added the area/yql YQL query language issues label Dec 23, 2024
@avevad avevad self-assigned this Dec 23, 2024
@avevad avevad requested a review from a team as a code owner December 23, 2024 14:59
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 23, 2024
@avevad avevad enabled auto-merge (squash) December 23, 2024 15:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 15:03:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3c74807 has started.
⚫ 2024-12-23 15:04:59 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 15:03:50 UTC Pre-commit check linux-x86_64-release-asan for 3c74807 has started.
⚪ 2024-12-23 15:04:01 UTC Artifacts will be uploaded here
⚫ 2024-12-23 15:05:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 15:06:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for ee9a934 has started.
⚪ 2024-12-23 15:06:35 UTC Artifacts will be uploaded here
⚪ 2024-12-23 15:09:12 UTC ya make is running...
⚫ 2024-12-23 15:10:34 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 15:07:04 UTC Pre-commit check linux-x86_64-release-asan for ee9a934 has started.
⚪ 2024-12-23 15:07:41 UTC Artifacts will be uploaded here
⚫ 2024-12-23 15:10:32 UTC Check cancelled

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 15:12:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5314f7a has started.
⚪ 2024-12-23 15:12:06 UTC Artifacts will be uploaded here
⚪ 2024-12-23 15:14:39 UTC ya make is running...
🟢 2024-12-23 15:16:16 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-23 15:16:22 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

⚪ 2024-12-23 15:12:59 UTC Pre-commit check linux-x86_64-release-asan for 5314f7a has started.
⚪ 2024-12-23 15:13:12 UTC Artifacts will be uploaded here
⚪ 2024-12-23 15:15:47 UTC ya make is running...
🟢 2024-12-23 15:17:06 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-23 15:17:12 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

blinkov
blinkov previously requested changes Dec 27, 2024
View reviewed changes
ydb/docs/ru/core/yql/reference/yql-core/udf/list/digest.md Outdated
* `Digest::CityHash128(String{Flags:AutoMap}) -> Tuple<Uint64,Uint64>`

Функции для видов хешей, которые поддерживают значение-параметр seed/init, принимают его опциональным именованным аргументом `Init`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seed является вполне устоявшимся термином конкретно для такого, а Init — слишком общее слово. Я бы рекомендовал переименовать это всё в Seed, а Init не использовать.

ydb/docs/ru/core/yql/reference/yql-core/udf/list/digest.md Outdated
* `Digest::CityHash128(String{Flags:AutoMap}) -> Tuple<Uint64,Uint64>`

Функции для видов хешей, которые поддерживают значение-параметр seed/init, принимают его опциональным именованным аргументом `Init`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Плюс этого абзаца нет в английской версии.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дописал

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 07:57:12 UTC Pre-commit check linux-x86_64-release-asan for 621f796 has started.
⚪ 2024-12-27 07:57:24 UTC Artifacts will be uploaded here
⚪ 2024-12-27 07:59:44 UTC ya make is running...
🟢 2024-12-27 08:01:09 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-27 08:01:16 UTC Build successful.

@avevad avevad requested a review from blinkov December 27, 2024 07:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2024 •
edited
Loading

⚪ 2024-12-27 07:58:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 621f796 has started.
⚪ 2024-12-27 07:58:15 UTC Artifacts will be uploaded here
⚪ 2024-12-27 08:00:38 UTC ya make is running...
🟢 2024-12-27 08:01:39 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-27 08:01:44 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@blinkov blinkov dismissed their stale review January 13, 2025 02:24

dismiss

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 02:30:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 56fac3e has started.
⚪ 2025-01-13 02:30:42 UTC Artifacts will be uploaded here
⚪ 2025-01-13 02:33:07 UTC ya make is running...
🟢 2025-01-13 02:34:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 02:34:40 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 02:30:38 UTC Pre-commit check linux-x86_64-release-asan for 56fac3e has started.
⚪ 2025-01-13 02:30:49 UTC Artifacts will be uploaded here
⚪ 2025-01-13 02:33:15 UTC ya make is running...
🟢 2025-01-13 02:34:49 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 02:34:55 UTC Build successful.

@github-actions GitHub Actions
Copy link

❌ Documentation build

Revision build failed

@blinkov blinkov added the rebase-and-check Rebase PR with the current base branch and check label Jan 13, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 02:52:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 56fac3e has started.
⚪ 2025-01-13 02:52:33 UTC Artifacts will be uploaded here
⚪ 2025-01-13 02:54:56 UTC ya make is running...
🟢 2025-01-13 02:55:01 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 02:55:07 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

⚪ 2025-01-13 02:52:31 UTC Pre-commit check linux-x86_64-release-asan for 56fac3e has started.
⚪ 2025-01-13 02:52:43 UTC Artifacts will be uploaded here
⚪ 2025-01-13 02:55:07 UTC ya make is running...
🟢 2025-01-13 02:55:13 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-13 02:55:18 UTC Build successful.

@avevad avevad merged commit 57cc933 into ydb-platform:main Jan 13, 2025
18 of 19 checks passed
@avevad avevad deleted the avevad-patch-13 branch January 17, 2025 12:31
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@avevad @azevaykin
Update docs for Digest (ydb-platform#12889)
7822867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blinkov blinkov blinkov left review comments

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees

@avevad avevad

Labels
area/yql YQL query language issues documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avevad @blinkov @fomichev3000