Use google breakpad in ydbd #12894

iddqdex · 2024-12-23T17:28:20Z

KIKIMR-18829

github-actions · 2024-12-23T17:32:17Z

⚪ 2024-12-23 17:32:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 60b41b4 has started.
⚪ 2024-12-23 17:32:29 UTC Artifacts will be uploaded here
⚪ 2024-12-23 17:35:07 UTC ya make is running...
⚫ 2024-12-23 17:37:32 UTC Check cancelled

github-actions · 2024-12-23T17:32:31Z

⚪ 2024-12-23 17:32:31 UTC Pre-commit check linux-x86_64-release-asan for 60b41b4 has started.
⚪ 2024-12-23 17:33:48 UTC Artifacts will be uploaded here
⚪ 2024-12-23 17:36:26 UTC ya make is running...
⚫ 2024-12-23 17:37:28 UTC Check cancelled

github-actions · 2024-12-23T17:41:26Z

⚪ 2024-12-23 17:41:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for c939bcb has started.
⚪ 2024-12-23 17:41:36 UTC Artifacts will be uploaded here
⚪ 2024-12-23 17:44:04 UTC ya make is running...
🟡 2024-12-23 18:19:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4409	4294	0	1	36	78

⚪ 2024-12-23 18:19:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-23 18:24:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
88 (only retried tests)	14	0	0	0	74

🟢 2024-12-23 18:24:10 UTC Build successful.
🟡 2024-12-23 18:24:22 UTC ydbd size 2.1 GiB changed* by +344.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `9dd07f5`	merge: `c939bcb`	diff	diff %
ydbd size	2 234 950 056 Bytes	2 235 302 312 Bytes	+344.0 KiB	+0.016%
ydbd stripped size	477 965 648 Bytes	478 059 472 Bytes	+91.6 KiB	+0.020%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-23T17:41:41Z

⚪ 2024-12-23 17:41:40 UTC Pre-commit check linux-x86_64-release-asan for c939bcb has started.
⚪ 2024-12-23 17:41:52 UTC Artifacts will be uploaded here
⚪ 2024-12-23 17:44:28 UTC ya make is running...
🟡 2024-12-23 18:34:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1693	1668	0	12	8	5

🟢 2024-12-23 18:34:18 UTC Build successful.
🟡 2024-12-23 18:34:34 UTC ydbd size 3.6 GiB changed* by +521.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `22f4d0c`	merge: `c939bcb`	diff	diff %
ydbd size	3 865 630 536 Bytes	3 866 164 840 Bytes	+521.8 KiB	+0.014%
ydbd stripped size	1 350 670 096 Bytes	1 350 934 240 Bytes	+258.0 KiB	+0.020%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/library/breakpad/minidumps.cpp

github-actions · 2024-12-24T08:45:55Z

⚪ 2024-12-24 08:45:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for f26cff7 has started.
⚪ 2024-12-24 08:46:05 UTC Artifacts will be uploaded here
⚪ 2024-12-24 08:48:34 UTC ya make is running...
🟡 2024-12-24 09:25:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4409	4297	0	1	36	75

⚪ 2024-12-24 09:26:00 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 09:29:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
86 (only retried tests)	12	0	0	0	74

🟢 2024-12-24 09:29:24 UTC Build successful.
🟡 2024-12-24 09:29:35 UTC ydbd size 2.1 GiB changed* by +247.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `18ed18e`	merge: `f26cff7`	diff	diff %
ydbd size	2 235 030 744 Bytes	2 235 284 048 Bytes	+247.4 KiB	+0.011%
ydbd stripped size	477 983 088 Bytes	478 056 080 Bytes	+71.3 KiB	+0.015%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-24T08:45:56Z

⚪ 2024-12-24 08:45:55 UTC Pre-commit check linux-x86_64-release-asan for f26cff7 has started.
⚪ 2024-12-24 08:46:08 UTC Artifacts will be uploaded here
⚪ 2024-12-24 08:48:46 UTC ya make is running...
🟡 2024-12-24 09:34:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1693	1669	0	12	6	6

🟢 2024-12-24 09:35:00 UTC Build successful.
🟡 2024-12-24 09:35:16 UTC ydbd size 3.6 GiB changed* by +476.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `18ed18e`	merge: `f26cff7`	diff	diff %
ydbd size	3 865 652 864 Bytes	3 866 140 584 Bytes	+476.3 KiB	+0.013%
ydbd stripped size	1 350 678 768 Bytes	1 350 929 728 Bytes	+245.1 KiB	+0.019%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/library/breakpad/minidumps.cpp

maximyurchuk · 2024-12-24T09:46:47Z

ydb/library/breakpad/minidumps.cpp

+            if (auto pid = fork()) {
+                waitpid(pid, 0, 0);
+            } else {
+                char* dumpSucceded = succeeded ? (char *)"true" : (char *)"false";  


Кастовать константную строку к char* наверное не самая лучшая идея

Тем более непонятно зачем: execve принимает const char* вроде

Там char* нужен execve. А константная строка это и есть const char *

Я может не понимаю, но как будто там везде const
https://man7.org/linux/man-pages/man2/execve.2.html

Не, там в апи древняя упячка со времён когда ещё не было никаких const. В массиве элементы - не const.

Ну окей, тогда я бы предложил скопировать в писабельную память и ее передавать

Просто это стремно же

Но я не настаиваю

ydb/tests/functional/minidumps/test_break.py

ydb/deploy/docker/Dockerfile

github-actions · 2024-12-24T12:19:34Z

⚪ 2024-12-24 12:19:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for bb057f2 has started.
⚪ 2024-12-24 12:19:39 UTC Artifacts will be uploaded here
⚪ 2024-12-24 12:22:05 UTC ya make is running...
🟡 2024-12-24 12:48:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
4409	4294	0	2	36	77

⚪ 2024-12-24 12:49:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-24 12:53:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
92 (only retried tests)	17	0	0	1	74

🟢 2024-12-24 12:53:20 UTC Build successful.
🟡 2024-12-24 12:53:31 UTC ydbd size 2.1 GiB changed* by +275.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `7cd35f3`	merge: `bb057f2`	diff	diff %
ydbd size	2 235 028 664 Bytes	2 235 310 984 Bytes	+275.7 KiB	+0.013%
ydbd stripped size	477 983 088 Bytes	478 062 288 Bytes	+77.3 KiB	+0.017%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-24T12:21:51Z

⚪ 2024-12-24 12:21:51 UTC Pre-commit check linux-x86_64-release-asan for bb057f2 has started.
⚪ 2024-12-24 12:22:02 UTC Artifacts will be uploaded here
⚪ 2024-12-24 12:24:37 UTC ya make is running...
🟡 2024-12-24 12:51:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
1693	1671	0	8	9	5

🟢 2024-12-24 12:51:56 UTC Build successful.
🟡 2024-12-24 12:52:11 UTC ydbd size 3.6 GiB changed* by +548.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `7cd35f3`	merge: `bb057f2`	diff	diff %
ydbd size	3 865 652 520 Bytes	3 866 214 056 Bytes	+548.4 KiB	+0.015%
ydbd stripped size	1 350 679 408 Bytes	1 350 951 584 Bytes	+265.8 KiB	+0.020%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

This reverts commit c594576.

…b-platform#12980)" This reverts commit fd6bcad.

Use google breakpad in ydbd

705282e

KIKIMR-18829

iddqdex requested review from sourcecd, maximyurchuk and kobzonega December 23, 2024 17:28

style

44757a5

sourcecd previously approved these changes Dec 23, 2024

View reviewed changes

shmel1k previously approved these changes Dec 23, 2024

View reviewed changes

snaury reviewed Dec 24, 2024

View reviewed changes

ydb/library/breakpad/minidumps.cpp Outdated Show resolved Hide resolved

do not use allocator on exec script

f5c4ca2

iddqdex dismissed stale reviews from shmel1k and sourcecd via f5c4ca2 December 24, 2024 08:44

snaury previously approved these changes Dec 24, 2024

View reviewed changes

maximyurchuk reviewed Dec 24, 2024

View reviewed changes

ydb/library/breakpad/minidumps.cpp Show resolved Hide resolved

maximyurchuk reviewed Dec 24, 2024

View reviewed changes

ydb/tests/functional/minidumps/test_break.py Outdated Show resolved Hide resolved

maximyurchuk reviewed Dec 24, 2024

View reviewed changes

ydb/tests/functional/minidumps/test_break.py Outdated Show resolved Hide resolved

maximyurchuk reviewed Dec 24, 2024

View reviewed changes

ydb/tests/functional/minidumps/test_break.py Outdated Show resolved Hide resolved

kobzonega reviewed Dec 24, 2024

View reviewed changes

ydb/deploy/docker/Dockerfile Show resolved Hide resolved

ydb/deploy/docker/Dockerfile Outdated Show resolved Hide resolved

Fix issues

a8b223d

iddqdex dismissed snaury’s stale review via a8b223d December 24, 2024 12:17

maximyurchuk approved these changes Dec 24, 2024

View reviewed changes

iddqdex enabled auto-merge (squash) December 24, 2024 12:37

iddqdex merged commit c594576 into ydb-platform:main Dec 24, 2024
12 checks passed

iddqdex deleted the breakpad branch December 24, 2024 13:06

GrigoriyPA mentioned this pull request Dec 25, 2024

Fixed empty error from CMS create tenant request #12977

Merged

iddqdex added a commit to iddqdex/ydb that referenced this pull request Dec 25, 2024

Revert "Use google breakpad in ydbd (ydb-platform#12894)"

df5f487

This reverts commit c594576.

iddqdex added a commit that referenced this pull request Dec 25, 2024

Revert "Use google breakpad in ydbd (#12894)" (#12980)

fd6bcad

iddqdex added a commit to iddqdex/ydb that referenced this pull request Dec 25, 2024

Revert "Revert "Use google breakpad in ydbd (ydb-platform#12894)" (yd…

ee5916b

…b-platform#12980)" This reverts commit fd6bcad.

GrigoriyPA mentioned this pull request Dec 27, 2024

YQ-3949 fix pq source sensors names #13088

Merged

GrigoriyPA mentioned this pull request Jan 5, 2025

KqpRun improved multi query mode and storage settings #13177

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use google breakpad in ydbd #12894

Use google breakpad in ydbd #12894

iddqdex commented Dec 23, 2024

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

maximyurchuk Dec 24, 2024

maximyurchuk Dec 24, 2024

iddqdex Dec 24, 2024

maximyurchuk Dec 24, 2024

snaury Dec 24, 2024

maximyurchuk Dec 24, 2024

maximyurchuk Dec 24, 2024

github-actions bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

Use google breakpad in ydbd #12894

Use google breakpad in ydbd #12894

Conversation

iddqdex commented Dec 23, 2024

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 • edited Loading

github-actions bot commented Dec 24, 2024 • edited Loading

github-actions bot commented Dec 24, 2024 • edited Loading

maximyurchuk Dec 24, 2024

Choose a reason for hiding this comment

maximyurchuk Dec 24, 2024

Choose a reason for hiding this comment

iddqdex Dec 24, 2024

Choose a reason for hiding this comment

maximyurchuk Dec 24, 2024

Choose a reason for hiding this comment

snaury Dec 24, 2024

Choose a reason for hiding this comment

maximyurchuk Dec 24, 2024

Choose a reason for hiding this comment

maximyurchuk Dec 24, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 24, 2024 • edited Loading

github-actions bot commented Dec 24, 2024 • edited Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading

github-actions bot commented Dec 24, 2024 •

edited

Loading