Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict writing data validation #13190

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

@ivanmorozov333 ivanmorozov333 commented Jan 7, 2025

valid after #13214

  • Improvement

Copy link

github-actions bot commented Jan 7, 2025

2025-01-07 12:21:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for e712090 has started.
2025-01-07 12:21:35 UTC Artifacts will be uploaded here
2025-01-07 12:24:26 UTC ya make is running...
🟡 2025-01-07 13:09:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18378 17072 0 11 1169 126

2025-01-07 13:10:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 13:22:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
206 (only retried tests) 78 0 7 0 121

2025-01-07 13:22:50 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-07 13:34:05 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 65 0 6 0 119

🟢 2025-01-07 13:34:12 UTC Build successful.
🟢 2025-01-07 13:34:35 UTC ydbd size 2.1 GiB changed* by +512 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2876ba4 merge: e712090 diff diff %
ydbd size 2 244 193 944 Bytes 2 244 194 456 Bytes +512 Bytes +0.000%
ydbd stripped size 472 320 624 Bytes 472 320 688 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 7, 2025

2025-01-07 12:21:24 UTC Pre-commit check linux-x86_64-release-asan for e712090 has started.
2025-01-07 12:21:36 UTC Artifacts will be uploaded here
2025-01-07 12:24:26 UTC ya make is running...
🟡 2025-01-07 13:27:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11463 11344 0 77 14 28

2025-01-07 13:28:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-07 13:41:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 128 0 8 0 27

2025-01-07 13:41:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-07 13:52:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 34 0 7 0 26

🟢 2025-01-07 13:53:00 UTC Build successful.
🟢 2025-01-07 13:53:30 UTC ydbd size 3.6 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2876ba4 merge: e712090 diff diff %
ydbd size 3 873 639 440 Bytes 3 873 640 544 Bytes +1.1 KiB +0.000%
ydbd stripped size 1 350 625 264 Bytes 1 350 625 328 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review January 7, 2025 15:20
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner January 7, 2025 15:20
@ivanmorozov333 ivanmorozov333 force-pushed the strict_writing_data_validation branch from 7ce8a4a to 3976f9e Compare January 9, 2025 10:26
Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 10:30:29 UTC Pre-commit check linux-x86_64-release-asan for e416188 has started.
2025-01-09 10:30:40 UTC Artifacts will be uploaded here
2025-01-09 10:33:29 UTC ya make is running...
🟡 2025-01-09 11:34:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11464 11400 0 28 8 28

2025-01-09 11:35:47 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 11:47:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 66 0 9 6 24

2025-01-09 11:47:47 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-09 11:56:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 40 0 5 0 24

🟢 2025-01-09 11:56:15 UTC Build successful.
🟢 2025-01-09 11:56:45 UTC ydbd size 3.6 GiB changed* by +4.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0859ec3 merge: e416188 diff diff %
ydbd size 3 874 438 760 Bytes 3 874 443 048 Bytes +4.2 KiB +0.000%
ydbd stripped size 1 350 831 216 Bytes 1 350 830 256 Bytes -960 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 10:30:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for e416188 has started.
2025-01-09 10:30:49 UTC Artifacts will be uploaded here
2025-01-09 10:33:38 UTC ya make is running...
🟡 2025-01-09 11:18:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18382 17081 0 9 1169 123

2025-01-09 11:19:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-09 11:35:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
195 (only retried tests) 69 0 7 0 119

2025-01-09 11:35:24 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-09 11:47:19 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 62 0 7 0 117

🟢 2025-01-09 11:47:27 UTC Build successful.
🟢 2025-01-09 11:47:50 UTC ydbd size 2.1 GiB changed* by +2.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 592bc99 merge: e416188 diff diff %
ydbd size 2 244 699 432 Bytes 2 244 702 088 Bytes +2.6 KiB +0.000%
ydbd stripped size 472 406 672 Bytes 472 406 288 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jan 10, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 09:10:27 UTC Pre-commit check linux-x86_64-release-asan for 10f4539 has started.
2025-01-10 09:10:39 UTC Artifacts will be uploaded here
2025-01-10 09:13:31 UTC ya make is running...
🟡 2025-01-10 10:10:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11473 11405 0 37 3 28

2025-01-10 10:11:34 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-10 10:22:44 UTC ydbd size 3.6 GiB changed* by +28.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7c8ed01 merge: 10f4539 diff diff %
ydbd size 3 874 705 456 Bytes 3 874 735 024 Bytes +28.9 KiB +0.001%
ydbd stripped size 1 350 949 584 Bytes 1 350 959 568 Bytes +9.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-10 10:22:46 UTC Check cancelled

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 09:10:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 10f4539 has started.
2025-01-10 09:10:45 UTC Artifacts will be uploaded here
2025-01-10 09:13:33 UTC ya make is running...
🟡 2025-01-10 09:57:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18392 17093 0 6 1169 124

2025-01-10 09:58:43 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-10 10:11:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 72 0 0 0 119

🟢 2025-01-10 10:11:25 UTC Build successful.
🟢 2025-01-10 10:11:45 UTC ydbd size 2.1 GiB changed* by +2.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6138376 merge: 10f4539 diff diff %
ydbd size 2 244 841 232 Bytes 2 244 843 888 Bytes +2.6 KiB +0.000%
ydbd stripped size 472 434 896 Bytes 472 434 512 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

nikvas0
nikvas0 previously approved these changes Jan 10, 2025
nikvas0
nikvas0 previously approved these changes Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 10:23:53 UTC Pre-commit check linux-x86_64-release-asan for c0f9c5c has started.
2025-01-10 10:24:24 UTC Artifacts will be uploaded here
2025-01-10 10:28:05 UTC ya make is running...
🔴 2025-01-10 10:30:59 UTC Build failed, see the logs. Also see fail summary

swalrus1
swalrus1 previously approved these changes Jan 10, 2025
nikvas0
nikvas0 previously approved these changes Jan 10, 2025
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 10:27:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for c0f9c5c has started.
2025-01-10 10:27:27 UTC Artifacts will be uploaded here
2025-01-10 10:30:18 UTC ya make is running...
🔴 2025-01-10 10:32:57 UTC Build failed, see the logs. Also see fail summary

@ivanmorozov333 ivanmorozov333 dismissed stale reviews from nikvas0 and swalrus1 via 020301c January 10, 2025 11:27
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 11:29:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for a4c577b has started.
2025-01-10 11:29:43 UTC Artifacts will be uploaded here
2025-01-10 11:32:32 UTC ya make is running...
🟡 2025-01-10 12:41:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18392 17085 0 11 1169 127

2025-01-10 12:43:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 12:55:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
206 (only retried tests) 75 0 9 0 122

2025-01-10 12:55:28 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-10 13:06:37 UTC ydbd size 2.1 GiB changed* by +81.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1d239d7 merge: a4c577b diff diff %
ydbd size 2 244 854 136 Bytes 2 244 937 072 Bytes +81.0 KiB +0.004%
ydbd stripped size 472 437 456 Bytes 472 443 152 Bytes +5.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-10 13:06:39 UTC Check cancelled

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 11:30:22 UTC Pre-commit check linux-x86_64-release-asan for a4c577b has started.
2025-01-10 11:30:36 UTC Artifacts will be uploaded here
2025-01-10 11:33:34 UTC ya make is running...
🟡 2025-01-10 13:01:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11473 11398 0 34 8 33

2025-01-10 13:02:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 13:06:43 UTC ydbd size 3.6 GiB changed* by +154.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1d239d7 merge: a4c577b diff diff %
ydbd size 3 874 753 760 Bytes 3 874 911 848 Bytes +154.4 KiB +0.004%
ydbd stripped size 1 350 966 800 Bytes 1 350 994 032 Bytes +26.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-10 13:06:45 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 changed the title Strict writing data validation strict writing data validation Jan 10, 2025
@ivanmorozov333 ivanmorozov333 force-pushed the strict_writing_data_validation branch from 7de3fea to 65bf25e Compare January 10, 2025 13:08
Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 13:11:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5fc600f has started.
2025-01-10 13:11:13 UTC Artifacts will be uploaded here
2025-01-10 13:12:04 UTC Check cancelled

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 13:13:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 54d8ab1 has started.
2025-01-10 13:13:51 UTC Artifacts will be uploaded here
2025-01-10 13:16:39 UTC ya make is running...
🟡 2025-01-10 14:06:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18392 17085 0 13 1169 125

🟢 2025-01-10 14:08:22 UTC ydbd size 2.1 GiB changed* by +6.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f5f4a12 merge: 54d8ab1 diff diff %
ydbd size 2 244 922 968 Bytes 2 244 929 984 Bytes +6.9 KiB +0.000%
ydbd stripped size 472 441 872 Bytes 472 442 192 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 13:13:46 UTC Pre-commit check linux-x86_64-release-asan for 54d8ab1 has started.
2025-01-10 13:14:17 UTC Artifacts will be uploaded here
2025-01-10 13:17:54 UTC ya make is running...
🟡 2025-01-10 14:19:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11473 11395 0 37 10 31

2025-01-10 14:20:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 14:32:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 96 0 11 0 27

🟢 2025-01-10 14:33:11 UTC ydbd size 3.6 GiB changed* by +17.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f5f4a12 merge: 54d8ab1 diff diff %
ydbd size 3 874 879 552 Bytes 3 874 897 296 Bytes +17.3 KiB +0.000%
ydbd stripped size 1 350 984 496 Bytes 1 350 989 744 Bytes +5.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-01-10 14:33:13 UTC Check cancelled

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 14:37:35 UTC Pre-commit check linux-x86_64-release-asan for 2959c8e has started.
2025-01-10 14:37:48 UTC Artifacts will be uploaded here
2025-01-10 14:40:47 UTC ya make is running...
2025-01-10 14:53:12 UTC Check cancelled

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 14:39:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2959c8e has started.
2025-01-10 14:39:16 UTC Artifacts will be uploaded here
2025-01-10 14:42:10 UTC ya make is running...
2025-01-10 14:53:05 UTC Check cancelled

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 14:54:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for b2b1497 has started.
2025-01-10 14:55:37 UTC Artifacts will be uploaded here
2025-01-10 14:58:58 UTC ya make is running...
🟡 2025-01-10 15:43:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18752 17450 0 5 1169 128

2025-01-10 15:44:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-10 15:56:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
195 (only retried tests) 72 0 0 0 123

🟢 2025-01-10 15:56:07 UTC Build successful.
🟢 2025-01-10 15:56:27 UTC ydbd size 2.1 GiB changed* by +13.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1a38741 merge: b2b1497 diff diff %
ydbd size 2 245 015 256 Bytes 2 245 028 664 Bytes +13.1 KiB +0.001%
ydbd stripped size 472 462 576 Bytes 472 464 368 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 10, 2025

2025-01-10 14:57:40 UTC Pre-commit check linux-x86_64-release-asan for b2b1497 has started.
2025-01-10 14:57:51 UTC Artifacts will be uploaded here
2025-01-10 15:00:42 UTC ya make is running...
🟡 2025-01-10 15:58:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11629 11575 0 20 2 32

2025-01-10 15:59:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-10 16:11:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 68 0 1 1 25

2025-01-10 16:11:18 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-10 16:23:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
52 (only retried tests) 25 0 1 0 26

🟢 2025-01-10 16:23:36 UTC Build successful.
🟢 2025-01-10 16:24:08 UTC ydbd size 3.6 GiB changed* by +23.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1a38741 merge: b2b1497 diff diff %
ydbd size 3 875 059 232 Bytes 3 875 083 168 Bytes +23.4 KiB +0.001%
ydbd stripped size 1 351 054 864 Bytes 1 351 062 096 Bytes +7.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit af411bb into ydb-platform:main Jan 10, 2025
12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the strict_writing_data_validation branch January 10, 2025 18:15
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants