Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add information about 'WITH' in CREATE GROUP #13717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: Add information about 'WITH' in CREATE GROUP #13717

wants to merge 1 commit into from
+48 −6

Conversation

flown4qqqq
Copy link
Collaborator

@flown4qqqq flown4qqqq commented Jan 22, 2025 •
edited
Loading

Changelog entry

Improvements in documentation about CREATE GROUP.

Changelog category

  • Improvement

Additional information

Add information about 'WITH' in CREATE GROUP (a test case has been around for a long time:

ydb/ydb/core/kqp/ut/service/kqp_qs_queries_ut.cpp

Line 2116 in bb0182c

CREATE GROUP group3 WITH USER user1;
)

@flown4qqqq flown4qqqq requested a review from a team as a code owner January 22, 2025 13:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 13:40:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3303080 has started.
⚪ 2025-01-22 13:41:36 UTC Artifacts will be uploaded here
⚪ 2025-01-22 13:44:01 UTC ya make is running...
🔴 2025-01-22 13:44:32 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 13:40:45 UTC Pre-commit check linux-x86_64-release-asan for 3303080 has started.
⚪ 2025-01-22 13:40:58 UTC Artifacts will be uploaded here
⚪ 2025-01-22 13:43:32 UTC ya make is running...
🔴 2025-01-22 13:44:08 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (4)

❌ /en/yql/reference/syntax/create-group.md: 22: MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Examples {#examples}"]

❌ /en/yql/reference/syntax/create-group.md: 23: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```yql"]

❌ /ru/yql/reference/syntax/create-group.md: 22: MD022/blanks-around-headings Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "## Примеры {#examples}"]

❌ /ru/yql/reference/syntax/create-group.md: 23: MD031/blanks-around-fences Fenced code blocks should be surrounded by blank lines [Context: "```yql"]

@flown4qqqq flown4qqqq force-pushed the improve-docs-create-group branch from edce91a to 1707bc7 Compare January 22, 2025 13:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 13:48:29 UTC Pre-commit check linux-x86_64-release-asan for 496af82 has started.
⚪ 2025-01-22 13:49:02 UTC Artifacts will be uploaded here
⚪ 2025-01-22 13:52:13 UTC ya make is running...
🟢 2025-01-22 13:53:50 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-22 13:53:56 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 13:49:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 496af82 has started.
⚪ 2025-01-22 13:50:06 UTC Artifacts will be uploaded here
⚪ 2025-01-22 13:52:38 UTC ya make is running...
🟢 2025-01-22 13:54:10 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-22 13:54:15 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@flown4qqqq flown4qqqq changed the title improving in docs Add information about 'WITH' in CREATE GROUP Jan 22, 2025
@flown4qqqq flown4qqqq changed the title Add information about 'WITH' in CREATE GROUP Docs: Add information about 'WITH' in CREATE GROUP Jan 22, 2025
@flown4qqqq flown4qqqq force-pushed the improve-docs-create-group branch from 1707bc7 to 538ff85 Compare January 22, 2025 17:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 17:37:22 UTC Pre-commit check linux-x86_64-release-asan for 8f91553 has started.
⚪ 2025-01-22 17:37:50 UTC Artifacts will be uploaded here
⚪ 2025-01-22 17:40:39 UTC ya make is running...
🟢 2025-01-22 17:42:07 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-22 17:42:13 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

⚪ 2025-01-22 17:37:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8f91553 has started.
⚪ 2025-01-22 17:37:55 UTC Artifacts will be uploaded here
⚪ 2025-01-22 17:40:57 UTC ya make is running...
🟢 2025-01-22 17:43:12 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-22 17:43:17 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

@flown4qqqq flown4qqqq force-pushed the improve-docs-create-group branch from 538ff85 to 4061671 Compare January 23, 2025 11:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 11:05:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for fd42e07 has started.
⚪ 2025-01-23 11:05:36 UTC Artifacts will be uploaded here
⚪ 2025-01-23 11:08:02 UTC ya make is running...
🔴 2025-01-23 11:09:32 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

❌ Documentation build

Revision build failed

Build logs

Errors (4)

❌ Link is unreachable: ../../../../concepts/glossary.md#access-group in /en/yql/reference/syntax/create-group.md

❌ Link is unreachable: ../../../../concepts/glossary.md#access-group in /ru/yql/reference/syntax/create-group.md

❌ Link is unreachable: ../../../../concepts/glossary.md#access-user in /en/yql/reference/syntax/create-group.md

❌ Link is unreachable: ../../../../concepts/glossary.md#access-user in /ru/yql/reference/syntax/create-group.md

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 11:08:37 UTC Pre-commit check linux-x86_64-release-asan for fd42e07 has started.
⚪ 2025-01-23 11:08:48 UTC Artifacts will be uploaded here
⚪ 2025-01-23 11:11:09 UTC ya make is running...
🔴 2025-01-23 11:12:07 UTC Build failed, see the logs. Also see fail summary

@flown4qqqq flown4qqqq force-pushed the improve-docs-create-group branch from 4061671 to 8c59aa4 Compare January 23, 2025 11:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 11:20:41 UTC Pre-commit check linux-x86_64-release-asan for dfa0071 has started.
⚪ 2025-01-23 11:20:49 UTC Artifacts will be uploaded here
⚪ 2025-01-23 11:23:18 UTC ya make is running...
🟢 2025-01-23 11:24:56 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-23 11:25:02 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 11:22:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for dfa0071 has started.
⚪ 2025-01-23 11:23:13 UTC Artifacts will be uploaded here
⚪ 2025-01-23 11:25:35 UTC ya make is running...
🟢 2025-01-23 11:25:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-01-23 11:25:46 UTC Build successful.

@github-actions GitHub Actions
Copy link

✅ Documentation build

Revision built successfully
Revision preview link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-bobkov anton-bobkov Awaiting requested review from anton-bobkov

@blinkov blinkov Awaiting requested review from blinkov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flown4qqqq @anton-bobkov