Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure minimum coordinator resolution with icb #13721

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 22, 2025

Changelog entry

Coordinator plan resolution can now be configured using immediate control board

Changelog category

  • Improvement

Additional information

Coordinators in large databases spend too much cpu time broadcasting planned steps to other nodes, which in turn hurts tail latency. This PR allows configuring the minimum plan resolution, which can help reducing the number of ticks per second produced by coordinators, indirectly reducing network-related activity and improving tail latency in large databases.

Additionally, it was discovered that plan step alignment was not working correctly due to almost all non-volatile transactions planning using "rapid" slots. Support for rapid planning has been removed and transactions are now always planned to some future step, which is aligned when possible.

Fixes #13693.

@snaury snaury self-assigned this Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

2025-01-22 14:04:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for a713624 has started.
2025-01-22 14:05:40 UTC Artifacts will be uploaded here
2025-01-22 14:08:55 UTC ya make is running...
🟡 2025-01-22 15:30:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27528 24993 0 7 2396 132

2025-01-22 15:33:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 15:45:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
197 (only retried tests) 76 0 3 0 118

2025-01-22 15:45:17 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-22 15:58:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 57 0 0 0 119

🟢 2025-01-22 15:58:49 UTC Build successful.
🟢 2025-01-22 15:59:14 UTC ydbd size 2.1 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2696900 merge: a713624 diff diff %
ydbd size 2 219 431 680 Bytes 2 219 434 088 Bytes +2.4 KiB +0.000%
ydbd stripped size 469 477 712 Bytes 469 477 968 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 22, 2025

2025-01-22 14:05:37 UTC Pre-commit check linux-x86_64-release-asan for a713624 has started.
2025-01-22 14:05:50 UTC Artifacts will be uploaded here
2025-01-22 14:09:09 UTC ya make is running...
🟡 2025-01-22 15:38:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13167 13082 0 24 30 31

2025-01-22 15:40:02 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 15:51:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 69 0 3 19 25

2025-01-22 15:51:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-22 16:03:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 43 0 2 0 26

🟢 2025-01-22 16:03:41 UTC Build successful.
🟢 2025-01-22 16:04:08 UTC ydbd size 3.6 GiB changed* by +3.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2696900 merge: a713624 diff diff %
ydbd size 3 856 062 480 Bytes 3 856 066 088 Bytes +3.5 KiB +0.000%
ydbd stripped size 1 348 628 848 Bytes 1 348 629 040 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review January 23, 2025 07:31
@snaury snaury requested a review from azevaykin January 23, 2025 07:31
@snaury snaury merged commit 48c14e3 into ydb-platform:main Jan 23, 2025
13 checks passed
@snaury snaury deleted the feature-13693-limit-volatile-plan-resolution branch January 23, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinator: allow configuring volatile plan resolution
2 participants