Introduce locality counters for single node tx. (#13415) #13735
Conversation
TotalSingleNodeReqCount - increases if tx touches the only one node (all shards located on the same node) NonLocalSingleNodeReqCount - increases if tx touches the only one node and this node is same with session node (node where located kqp session and grpc request accepted) * New feature
dcherednik
requested review from
mvgorbunov,
va-kuznecov and
a team
as code owners
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| @@ -1860,6 +1861,10 @@ class TKqpExecuterBase : public TActorBootstrapped<TDerived> { | |||
| LOG_N("Full stats: " << response.GetResult().GetStats()); | |||
| } | |||
| } | |||
|
|
|||
| for (const auto nodeId : ParticipantNodes) { | |||
| response.MutableResult()->AddParticipantNodes(nodeId); | |||
There was a problem hiding this comment.
это же локальное сообщение, зачем в протобуф перекладывать?
There was a problem hiding this comment.
По аналогии со статистикой. Вообще там не очевидно как использовать поля в TEvTxResponse
TotalSingleNodeReqCount - increases if tx touches the only one node (all shards located on the same node)
NonLocalSingleNodeReqCount - increases if tx touches the only one node and this node is same with session node (node where located kqp session and grpc request accepted)
Changelog entry
...
Changelog category
Additional information
...