Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed segmentation fault in ThrowOnError function #13736

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

Gazizonoki
Copy link
Collaborator

Changelog entry

TYdbErrorException constructor uses moved value, that leads to segfault

Changelog category

  • Bugfix

Additional information

...

@Gazizonoki Gazizonoki requested a review from a team as a code owner January 22, 2025 16:54
Copy link

github-actions bot commented Jan 22, 2025

2025-01-22 16:56:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for d031e65 has started.
2025-01-22 16:56:26 UTC Artifacts will be uploaded here
2025-01-22 16:59:31 UTC ya make is running...
🟡 2025-01-22 18:26:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27700 25156 0 7 2402 135

2025-01-22 18:28:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 18:38:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
213 (only retried tests) 94 0 1 0 118

2025-01-22 18:38:27 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-22 18:47:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 56 0 0 0 117

🟢 2025-01-22 18:47:55 UTC Build successful.
🟢 2025-01-22 18:48:17 UTC ydbd size 2.1 GiB changed* by -576 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 362d8a2 merge: d031e65 diff diff %
ydbd size 2 220 365 016 Bytes 2 220 364 440 Bytes -576 Bytes -0.000%
ydbd stripped size 469 653 680 Bytes 469 653 552 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 22, 2025

2025-01-22 16:56:37 UTC Pre-commit check linux-x86_64-release-asan for d031e65 has started.
2025-01-22 16:56:41 UTC Artifacts will be uploaded here
2025-01-22 16:59:52 UTC ya make is running...
🟡 2025-01-22 18:32:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13375 13280 0 33 34 28

2025-01-22 18:33:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-22 18:46:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
147 (only retried tests) 108 0 4 7 28

2025-01-22 18:46:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-22 18:58:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 35 0 1 2 24

🟢 2025-01-22 18:58:31 UTC Build successful.
🟢 2025-01-22 18:58:59 UTC ydbd size 3.6 GiB changed* by -1.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1d4dae5 merge: d031e65 diff diff %
ydbd size 3 858 144 120 Bytes 3 858 142 816 Bytes -1.3 KiB -0.000%
ydbd stripped size 1 349 521 296 Bytes 1 349 520 656 Bytes -640 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Gazizonoki Gazizonoki merged commit 8749539 into ydb-platform:main Jan 22, 2025
13 checks passed
@Gazizonoki Gazizonoki deleted the fix-bug-throw-on-error branch January 22, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants