Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-3924 Add compiler actors to cpu stats #13745

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

YQ-3924 Add compiler actors to cpu stats #13745

wants to merge 3 commits into from
+14 −4

Conversation

kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@kardymonds kardymonds requested a review from a team as a code owner January 23, 2025 07:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 07:30:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 104c3cb has started.
⚪ 2025-01-23 07:30:26 UTC Artifacts will be uploaded here
⚪ 2025-01-23 07:33:19 UTC ya make is running...
🟡 2025-01-23 08:25:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25120 22575 0 7 2408 130

⚪ 2025-01-23 08:27:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 08:39:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 85 0 2 0 118

⚪ 2025-01-23 08:39:19 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-23 08:50:33 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 58 0 1 0 117

🟢 2025-01-23 08:50:40 UTC Build successful.
🟢 2025-01-23 08:51:06 UTC ydbd size 2.1 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 239f04b merge: 104c3cb diff diff %
ydbd size 2 220 425 536 Bytes 2 220 430 240 Bytes +4.6 KiB +0.000%
ydbd stripped size 469 665 968 Bytes 469 671 088 Bytes +5.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 07:30:31 UTC Pre-commit check linux-x86_64-release-asan for 104c3cb has started.
⚪ 2025-01-23 07:30:42 UTC Artifacts will be uploaded here
⚪ 2025-01-23 07:33:31 UTC ya make is running...
🟡 2025-01-23 08:30:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11051 10980 0 26 16 29

⚪ 2025-01-23 08:31:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 08:46:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 70 0 6 5 25

⚪ 2025-01-23 08:47:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-23 09:06:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 33 0 3 0 24

🟢 2025-01-23 09:07:05 UTC Build successful.
🟢 2025-01-23 09:07:34 UTC ydbd size 3.6 GiB changed* by -16.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 239f04b merge: 104c3cb diff diff %
ydbd size 3 858 284 696 Bytes 3 858 267 888 Bytes -16.4 KiB -0.000%
ydbd stripped size 1 349 564 656 Bytes 1 349 575 568 Bytes +10.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 10:38:07 UTC Pre-commit check linux-x86_64-release-asan for 20f0d5b has started.
⚪ 2025-01-23 10:38:18 UTC Artifacts will be uploaded here
⚪ 2025-01-23 10:41:08 UTC ya make is running...
🟡 2025-01-23 11:41:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11053 10964 0 43 16 30

⚪ 2025-01-23 11:42:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 11:56:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 104 0 3 8 27

⚪ 2025-01-23 11:56:18 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-23 12:07:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 30 0 4 2 25

🟢 2025-01-23 12:08:03 UTC Build successful.
🟢 2025-01-23 12:08:32 UTC ydbd size 3.6 GiB changed* by +9.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78fee80 merge: 20f0d5b diff diff %
ydbd size 3 858 261 672 Bytes 3 858 271 608 Bytes +9.7 KiB +0.000%
ydbd stripped size 1 349 573 328 Bytes 1 349 575 824 Bytes +2.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 10:40:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 20f0d5b has started.
⚪ 2025-01-23 10:40:44 UTC Artifacts will be uploaded here
⚪ 2025-01-23 10:43:33 UTC ya make is running...
🟡 2025-01-23 11:33:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25122 22593 0 5 2402 122

⚪ 2025-01-23 11:35:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 11:45:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
193 (only retried tests) 73 0 2 0 118

⚪ 2025-01-23 11:45:53 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-01-23 11:55:50 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 58 0 2 0 116

🟢 2025-01-23 11:55:57 UTC Build successful.
🟢 2025-01-23 11:56:20 UTC ydbd size 2.1 GiB changed* by +4.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 78fee80 merge: 20f0d5b diff diff %
ydbd size 2 220 428 304 Bytes 2 220 432 640 Bytes +4.2 KiB +0.000%
ydbd stripped size 469 670 576 Bytes 469 671 344 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 19:58:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for b32bc5e has started.
⚪ 2025-01-23 19:58:21 UTC Artifacts will be uploaded here
⚪ 2025-01-23 20:01:23 UTC ya make is running...
🟡 2025-01-23 20:58:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25125 22604 0 3 2397 121

⚪ 2025-01-23 21:00:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 21:10:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 62 0 1 0 119

⚪ 2025-01-23 21:10:30 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-23 21:20:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 57 0 0 0 119

🟢 2025-01-23 21:20:12 UTC Build successful.
🟢 2025-01-23 21:20:37 UTC ydbd size 2.1 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 432c205 merge: b32bc5e diff diff %
ydbd size 2 220 827 248 Bytes 2 220 831 648 Bytes +4.3 KiB +0.000%
ydbd stripped size 469 707 792 Bytes 469 708 624 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

⚪ 2025-01-23 19:58:24 UTC Pre-commit check linux-x86_64-release-asan for b32bc5e has started.
⚪ 2025-01-23 19:58:36 UTC Artifacts will be uploaded here
⚪ 2025-01-23 20:01:34 UTC ya make is running...
🟡 2025-01-23 21:00:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11053 10986 0 27 10 30

⚪ 2025-01-23 21:01:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 21:13:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 73 0 2 3 27

⚪ 2025-01-23 21:13:21 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-23 21:27:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
55 (only retried tests) 25 0 2 1 27

🟢 2025-01-23 21:27:57 UTC Build successful.
🟢 2025-01-23 21:28:27 UTC ydbd size 3.6 GiB changed* by +13.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 432c205 merge: b32bc5e diff diff %
ydbd size 3 858 896 264 Bytes 3 858 910 304 Bytes +13.7 KiB +0.000%
ydbd stripped size 1 349 672 144 Bytes 1 349 678 736 Bytes +6.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

dorooleg
dorooleg reviewed Jan 23, 2025
View reviewed changes
ydb/core/fq/libs/row_dispatcher/row_dispatcher.cpp
}
::NMonitoring::TDynamicCounters::TCounterPtr Session;
::NMonitoring::TDynamicCounters::TCounterPtr RowDispatcher;
::NMonitoring::TDynamicCounters::TCounterPtr Compiler;
::NMonitoring::TDynamicCounters::TCounterPtr CompilerActor;
::NMonitoring::TDynamicCounters::TCounterPtr CompilerService;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А где в этим метрики проставляются значения?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorooleg dorooleg dorooleg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kardymonds @dorooleg