correct validation for second init tx received #13773

ivanmorozov333 · 2025-01-23T16:13:24Z

Bugfix

github-actions · 2025-01-23T16:17:31Z

⚪ 2025-01-23 16:17:30 UTC Pre-commit check linux-x86_64-release-asan for c4541c1 has started.
⚪ 2025-01-23 16:18:13 UTC Artifacts will be uploaded here
⚪ 2025-01-23 16:21:14 UTC ya make is running...
🔴 2025-01-23 16:25:54 UTC Build failed, see the logs. Also see fail summary

github-actions · 2025-01-23T16:20:10Z

⚪ 2025-01-23 16:20:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for c4541c1 has started.
⚪ 2025-01-23 16:20:23 UTC Artifacts will be uploaded here
⚪ 2025-01-23 16:23:13 UTC ya make is running...
🔴 2025-01-23 16:27:01 UTC Build failed, see the logs. Also see fail summary

github-actions · 2025-01-23T17:04:29Z

⚪ 2025-01-23 17:04:29 UTC Pre-commit check linux-x86_64-release-asan for 98db6cd has started.
⚪ 2025-01-23 17:11:19 UTC Artifacts will be uploaded here
⚪ 2025-01-23 17:14:16 UTC ya make is running...
🟡 2025-01-23 18:16:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11186	11128	0	19	9	30

⚪ 2025-01-23 18:18:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-23 18:30:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
91 (only retried tests)	58	0	2	5	26

⚪ 2025-01-23 18:30:42 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-23 18:43:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
55 (only retried tests)	25	0	0	3	27

🟢 2025-01-23 18:43:35 UTC Build successful.
🟢 2025-01-23 18:44:03 UTC ydbd size 3.6 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `38d0188`	merge: `98db6cd`	diff	diff %
ydbd size	3 858 369 408 Bytes	3 858 371 360 Bytes	+1.9 KiB	+0.000%
ydbd stripped size	1 349 602 288 Bytes	1 349 602 352 Bytes	+64 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-23T17:05:42Z

⚪ 2025-01-23 17:05:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 98db6cd has started.
⚪ 2025-01-23 17:06:59 UTC Artifacts will be uploaded here
⚪ 2025-01-23 17:10:00 UTC ya make is running...
🟡 2025-01-23 18:44:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18429	17129	0	1	1180	119

github-actions · 2025-01-24T05:02:20Z

⚪ 2025-01-24 05:02:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 78f55c3 has started.
⚪ 2025-01-24 05:02:30 UTC Artifacts will be uploaded here
⚪ 2025-01-24 05:05:22 UTC ya make is running...
🟡 2025-01-24 05:55:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18430	17109	0	11	1181	129

⚪ 2025-01-24 05:56:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-24 06:08:55 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
202 (only retried tests)	81	0	0	1	120

🟢 2025-01-24 06:09:02 UTC Build successful.
🟢 2025-01-24 06:09:23 UTC ydbd size 2.1 GiB changed* by +752 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `9dde6c5`	merge: `78f55c3`	diff	diff %
ydbd size	2 220 825 024 Bytes	2 220 825 776 Bytes	+752 Bytes	+0.000%
ydbd stripped size	469 708 144 Bytes	469 708 144 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-24T05:02:43Z

⚪ 2025-01-24 05:02:43 UTC Pre-commit check linux-x86_64-release-asan for 78f55c3 has started.
⚪ 2025-01-24 05:02:57 UTC Artifacts will be uploaded here
⚪ 2025-01-24 05:05:54 UTC ya make is running...
🟡 2025-01-24 06:04:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11186	11127	0	19	10	30

⚪ 2025-01-24 06:05:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-24 06:17:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
92 (only retried tests)	62	0	1	0	29

⚪ 2025-01-24 06:17:31 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-24 06:33:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
53 (only retried tests)	24	0	0	3	26

🟢 2025-01-24 06:33:16 UTC Build successful.
🟢 2025-01-24 06:33:45 UTC ydbd size 3.6 GiB changed* by +2.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `9dde6c5`	merge: `78f55c3`	diff	diff %
ydbd size	3 858 888 616 Bytes	3 858 890 632 Bytes	+2.0 KiB	+0.000%
ydbd stripped size	1 349 668 816 Bytes	1 349 668 944 Bytes	+128 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

zverevgeny · 2025-01-24T08:55:23Z

ydb/core/tx/columnshard/transactions/operators/schema.h

@@ -24,7 +24,6 @@ class TSchemaTransactionOperator: public IProposeTxOperator, public TMonitoringO
    THashSet<ui64> GetNotErasedTableIds(const TColumnShard& owner, const TInfoProto& tables) const {
        THashSet<ui64> result;
        for (auto&& i : tables) {
-            AFL_VERIFY(!owner.TablesManager.HasTable(i.GetPathId()));


Предлагаю тут различать состояние таблиц в TableManager. Напр: Creating, Created, Deleting. Тогда можно будет делать более строгие проверки

correct validation for second init tx received

7ff47f5

ivanmorozov333 linked an issue Jan 23, 2025 that may be closed by this pull request

Crash during olap_workload #13358

Closed

github-actions bot added the bugfix label Jan 23, 2025

fix

3fac5ca

ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Jan 24, 2025

github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 24, 2025

ivanmorozov333 marked this pull request as ready for review January 24, 2025 06:38

ivanmorozov333 requested a review from a team as a code owner January 24, 2025 06:38

zverevgeny reviewed Jan 24, 2025

View reviewed changes

zverevgeny approved these changes Jan 24, 2025

View reviewed changes

ivanmorozov333 merged commit e47c645 into ydb-platform:main Jan 24, 2025
17 of 18 checks passed

ivanmorozov333 deleted the correct_validation_for_second_tablet_initialization branch January 24, 2025 09:41

GrigoriyPA mentioned this pull request Jan 27, 2025

YQ-4052 fixed url escaping for s3 insert #13891

Merged

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 29, 2025

correct validation for second init tx received (ydb-platform#13773)

509b042

GrigoriyPA mentioned this pull request Jan 30, 2025

YQ-4043 fixed hanging in kqp write actor #14017

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

correct validation for second init tx received #13773

correct validation for second init tx received #13773

ivanmorozov333 commented Jan 23, 2025

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

zverevgeny Jan 24, 2025

correct validation for second init tx received #13773

correct validation for second init tx received #13773

Conversation

ivanmorozov333 commented Jan 23, 2025

github-actions bot commented Jan 23, 2025 • edited Loading

github-actions bot commented Jan 23, 2025 • edited Loading

github-actions bot commented Jan 23, 2025 • edited Loading

github-actions bot commented Jan 23, 2025 • edited Loading

github-actions bot commented Jan 24, 2025 • edited Loading

github-actions bot commented Jan 24, 2025 • edited Loading

zverevgeny Jan 24, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 23, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading