Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemeshard: fix error handling of bad format in default_access #13784

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ijon
Copy link
Collaborator

@ijon ijon commented Jan 23, 2025

Avoid unhandled exception in case when security_config.default_access contains entry with bad permission format.

Changelog category

  • Not for changelog

Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 19:42:38 UTC Pre-commit check linux-x86_64-release-asan for 3581a82 has started.
2025-01-23 19:42:49 UTC Artifacts will be uploaded here
2025-01-23 19:45:42 UTC ya make is running...
🟡 2025-01-23 21:00:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11284 11227 0 15 10 32

2025-01-23 21:01:13 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-23 21:12:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
90 (only retried tests) 56 0 0 8 26

🟢 2025-01-23 21:13:06 UTC Build successful.
🟢 2025-01-23 21:13:31 UTC ydbd size 3.6 GiB changed* by +8.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 432c205 merge: 3581a82 diff diff %
ydbd size 3 858 896 264 Bytes 3 858 905 360 Bytes +8.9 KiB +0.000%
ydbd stripped size 1 349 672 144 Bytes 1 349 677 552 Bytes +5.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 23, 2025

2025-01-23 19:44:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3581a82 has started.
2025-01-23 19:44:31 UTC Artifacts will be uploaded here
2025-01-23 19:47:23 UTC ya make is running...
🟡 2025-01-23 20:31:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18736 17434 0 1 1180 121

2025-01-23 20:33:30 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-23 20:42:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 60 0 0 0 118

🟢 2025-01-23 20:42:56 UTC Build successful.
🟢 2025-01-23 20:43:15 UTC ydbd size 2.1 GiB changed* by +2.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 432c205 merge: 3581a82 diff diff %
ydbd size 2 220 827 248 Bytes 2 220 830 224 Bytes +2.9 KiB +0.000%
ydbd stripped size 469 707 792 Bytes 469 708 240 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ijon ijon requested a review from adameat January 24, 2025 08:02
@ijon ijon merged commit 672f2e5 into ydb-platform:main Jan 24, 2025
13 checks passed
@ijon ijon deleted the fix-crash-on-error-in-default-access branch January 24, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants