Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-4071 Fix exception handling in topic session #14055

Merged
merged 2 commits into from
Feb 3, 2025
Merged

YQ-4071 Fix exception handling in topic session #14055

merged 2 commits into from
Feb 3, 2025

Conversation

kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@kardymonds kardymonds requested a review from a team as a code owner January 31, 2025 07:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

⚪ 2025-01-31 07:11:30 UTC Pre-commit check linux-x86_64-release-asan for 226d712 has started.
⚪ 2025-01-31 07:12:23 UTC Artifacts will be uploaded here
⚪ 2025-01-31 07:15:30 UTC ya make is running...
⚫ 2025-01-31 07:59:41 UTC Check cancelled

@github-actions GitHub Actions
Copy link

⚪ 2025-01-31 07:11:30 UTC Pre-commit check linux-x86_64-release-asan for 226d712 has started.

@github-actions GitHub Actions
Copy link

⚪ 2025-01-31 07:13:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 226d712 has started.

dorooleg
dorooleg reviewed Jan 31, 2025
View reviewed changes
ydb/core/fq/libs/row_dispatcher/topic_session.cpp Outdated
@@ -782,7 +783,7 @@ void TTopicSession::RestartSessionIfOldestClient(const TClientsInfo& info) {
}
}

void TTopicSession::FatalError(TStatus status) {
void TTopicSession::FatalError(TStatus status, bool alreadyHasException) {
Copy link
Collaborator

@dorooleg dorooleg Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может эту функцию на две лучше разбить. ThrowFatalError и FatalError? А то в эти флажки потом сложно вникать и держать их в голове

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Jan 31, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

⚪ 2025-01-31 08:02:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for 226d712 has started.
⚪ 2025-01-31 08:02:53 UTC Artifacts will be uploaded here
⚪ 2025-01-31 08:05:56 UTC ya make is running...
⚫ 2025-01-31 08:42:54 UTC Check cancelled

@github-actions GitHub Actions
Copy link

⚪ 2025-01-31 08:03:07 UTC Pre-commit check linux-x86_64-release-asan for 226d712 has started.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

⚪ 2025-01-31 08:45:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e0a1ef has started.
⚪ 2025-01-31 08:46:55 UTC Artifacts will be uploaded here
⚪ 2025-01-31 08:50:44 UTC ya make is running...
🟡 2025-01-31 09:41:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25238 22519 0 2 2649 68

⚪ 2025-01-31 09:44:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 09:51:55 UTC ydbd size 2.1 GiB changed* by -4.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 59315fe merge: 7e0a1ef diff diff %
ydbd size 2 227 464 424 Bytes 2 227 459 504 Bytes -4.8 KiB -0.000%
ydbd stripped size 471 399 312 Bytes 471 398 416 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-01-31 09:51:57 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

⚪ 2025-01-31 08:45:46 UTC Pre-commit check linux-x86_64-release-asan for 7e0a1ef has started.
⚪ 2025-01-31 08:47:40 UTC Artifacts will be uploaded here
⚪ 2025-01-31 08:50:43 UTC ya make is running...
🟡 2025-01-31 09:49:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11106 11034 0 21 17 34

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Jan 31, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jan 31, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

⚪ 2025-01-31 09:53:55 UTC Pre-commit check linux-x86_64-release-asan for 7e0a1ef has started.
⚪ 2025-01-31 09:54:07 UTC Artifacts will be uploaded here
⚪ 2025-01-31 09:56:57 UTC ya make is running...
🟡 2025-01-31 10:54:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11101 11038 0 25 5 33

⚪ 2025-01-31 10:55:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 11:08:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
94 (only retried tests) 63 0 0 3 28

🟢 2025-01-31 11:08:24 UTC Build successful.
🟢 2025-01-31 11:08:51 UTC ydbd size 3.6 GiB changed* by -8.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dcb89a5 merge: 7e0a1ef diff diff %
ydbd size 3 870 408 176 Bytes 3 870 399 304 Bytes -8.7 KiB -0.000%
ydbd stripped size 1 353 716 976 Bytes 1 353 714 672 Bytes -2.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited
Loading

⚪ 2025-01-31 09:53:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e0a1ef has started.
⚪ 2025-01-31 09:54:11 UTC Artifacts will be uploaded here
⚪ 2025-01-31 09:57:17 UTC ya make is running...
🟡 2025-01-31 10:51:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
25238 22526 0 1 2644 67

⚪ 2025-01-31 10:54:26 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 11:06:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
363 (only retried tests) 231 0 0 8 124

🟢 2025-01-31 11:06:35 UTC Build successful.
🟢 2025-01-31 11:06:55 UTC ydbd size 2.1 GiB changed* by -4.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 59315fe merge: 7e0a1ef diff diff %
ydbd size 2 227 464 424 Bytes 2 227 459 504 Bytes -4.8 KiB -0.000%
ydbd stripped size 471 399 312 Bytes 471 398 416 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kardymonds kardymonds merged commit e122885 into ydb-platform:main Feb 3, 2025
16 of 18 checks passed
kardymonds added a commit to kardymonds/ydb that referenced this pull request Feb 3, 2025
@kardymonds
YQ-4071 Fix exception handling in topic session (ydb-platform#14055)
774664e
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@kardymonds @azevaykin
YQ-4071 Fix exception handling in topic session (ydb-platform#14055)
2f7b5ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorooleg dorooleg dorooleg approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kardymonds @dorooleg @maximyurchuk