Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topic: preliminary refactoring in the restore tool code #14083

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Jan 31, 2025

Preliminary refactoring so that the future addition of the BackupTopic function would have less diffs with the main branch.

Added SerializeTo and DeserializeFrom (in a form of a constructor) for some of the structures used in topic SDK. This way we would able to call CreateTopic on restore (see in the next PR) with TCreateTopicSettings built from the Ydb::Topic::CreateTopicRequest directly.

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 requested a review from a team as a code owner January 31, 2025 16:38

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

CyberROFL
CyberROFL previously approved these changes Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 17:32:08 UTC Pre-commit check linux-x86_64-release-asan for 2dfb404 has started.
2025-01-31 17:36:18 UTC Artifacts will be uploaded here
2025-01-31 17:39:25 UTC ya make is running...
🟡 2025-01-31 18:45:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13331 13267 0 19 15 30

2025-01-31 18:50:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 19:02:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 64 0 0 4 27

🟢 2025-01-31 19:02:19 UTC Build successful.
🟡 2025-01-31 19:02:44 UTC ydbd size 3.6 GiB changed* by +117.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 93ccaa9 merge: 2dfb404 diff diff %
ydbd size 3 870 979 096 Bytes 3 871 099 760 Bytes +117.8 KiB +0.003%
ydbd stripped size 1 353 831 536 Bytes 1 353 864 496 Bytes +32.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 17:33:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2dfb404 has started.
2025-01-31 17:36:04 UTC Artifacts will be uploaded here
2025-01-31 17:39:21 UTC ya make is running...
🟡 2025-01-31 19:35:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27617 25050 0 14 2427 126

2025-01-31 19:38:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-31 19:51:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 90 0 0 0 121

🟢 2025-01-31 19:51:18 UTC Build successful.
🟢 2025-01-31 19:51:39 UTC ydbd size 2.1 GiB changed* by +59.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4d23192 merge: 2dfb404 diff diff %
ydbd size 2 227 744 952 Bytes 2 227 805 336 Bytes +59.0 KiB +0.003%
ydbd stripped size 471 436 112 Bytes 471 442 416 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants