Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix inverted condition in TInputChannelInfo::IsPaused #14094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Jan 31, 2025

Grave-but-harmless: this function is only used in monitoring page for async CA, and when checkpoint are used in sync CA (this combination is not used anywhere)

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

fortunatelly, this function is only used in monitoring page for async
CA, and when checkpoint is used in sync actor (this combination is not
used anywhere)
@yumkam yumkam marked this pull request as ready for review January 31, 2025 17:48
@yumkam yumkam requested review from a team as code owners January 31, 2025 17:48
Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 17:52:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 065967d has started.
2025-01-31 17:53:00 UTC Artifacts will be uploaded here
2025-01-31 17:56:22 UTC ya make is running...
2025-01-31 18:18:45 UTC Check cancelled

Copy link

2025-01-31 17:59:10 UTC Pre-commit check linux-x86_64-release-asan for 065967d has started.

@@ -834,7 +834,7 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived>
}

bool IsPaused() const {
return PendingWatermarks.empty() || PendingCheckpoint.has_value();
return (!PendingWatermarks.empty()) || PendingCheckpoint.has_value();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Убери лишние скобки

Copy link

github-actions bot commented Jan 31, 2025

2025-01-31 18:24:52 UTC Pre-commit check linux-x86_64-release-asan for 8ec920e has started.
2025-01-31 18:26:04 UTC Artifacts will be uploaded here
2025-01-31 18:29:10 UTC ya make is running...
🟡 2025-01-31 19:31:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11507 11421 0 32 20 34

2025-01-31 19:33:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-31 19:45:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 94 0 1 5 29

2025-01-31 19:45:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-31 19:57:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 30 0 1 2 27

🟢 2025-01-31 19:57:46 UTC Build successful.
🟢 2025-01-31 19:58:15 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 71a3ed4 merge: 8ec920e diff diff %
ydbd size 3 871 025 512 Bytes 3 871 025 416 Bytes -96 Bytes -0.000%
ydbd stripped size 1 353 839 216 Bytes 1 353 839 152 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

2025-01-31 18:24:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8ec920e has started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants