-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix inverted condition in TInputChannelInfo::IsPaused #14094
base: main
Are you sure you want to change the base?
fix inverted condition in TInputChannelInfo::IsPaused #14094
Conversation
fortunatelly, this function is only used in monitoring page for async CA, and when checkpoint is used in sync actor (this combination is not used anywhere)
@@ -834,7 +834,7 @@ class TDqComputeActorBase : public NActors::TActorBootstrapped<TDerived> | |||
} | |||
|
|||
bool IsPaused() const { | |||
return PendingWatermarks.empty() || PendingCheckpoint.has_value(); | |||
return (!PendingWatermarks.empty()) || PendingCheckpoint.has_value(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Убери лишние скобки
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Grave-but-harmless: this function is only used in monitoring page for async CA, and when checkpoint are used in sync CA (this combination is not used anywhere)
Changelog entry
...
Changelog category
Additional information
...