Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace cpp sdk to v3 #7796

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Replace cpp sdk to v3 #7796

merged 7 commits into from
Jan 22, 2025

Conversation

Gazizonoki
Copy link
Collaborator

@Gazizonoki Gazizonoki commented Aug 14, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

SIMPLIFIED VERSION FOR REVIEW: #13417

Internal CI: https://nda.ya.ru/t/61blmXiB78Dj2L

TPC-C: https://datalens.yandex/2ohtijbghz3cq?tab=yV&state=4aa6e34b199

Влияние на performance ydbd на основе прогона бенчмарка TPC-C от 30.09.2024. Было сделано 2 прогона на этой ветке и 1 на main'е. Показатели:
image

Значения tpmc (больше - лучше):
image

Latency по перцентилям:
image

Latency 90-ый перцентиль (правый на main ветке, 2 левых - на текущей):
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 15:43:23 UTC Pre-commit check for 1db52d5 has started.
⚪ 2024-08-14 15:49:16 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-14 15:49:31 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 15:44:30 UTC Pre-commit check for 1db52d5 has started.
⚪ 2024-08-14 15:50:01 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 15:50:15 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 15:46:09 UTC Pre-commit check for 1db52d5 has started.
⚪ 2024-08-14 15:49:59 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-14 15:50:13 UTC Build failed. see the logs.

@Gazizonoki Gazizonoki force-pushed the replace-cpp-sdk-to-v2 branch from f99b323 to b6ea8a4 Compare August 14, 2024 16:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:10:53 UTC Pre-commit check for 8c6c379 has started.
⚪ 2024-08-14 16:14:39 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-14 16:14:53 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:10:53 UTC Pre-commit check for 8c6c379 has started.
⚫ 2024-08-14 16:16:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:12:12 UTC Pre-commit check for 8c6c379 has started.
⚪ 2024-08-14 16:15:46 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 16:15:59 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:19:19 UTC Pre-commit check for 58edcf3 has started.
⚪ 2024-08-14 16:22:53 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-14 16:23:07 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:19:22 UTC Pre-commit check for 58edcf3 has started.
⚪ 2024-08-14 16:23:04 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 16:23:18 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:19:24 UTC Pre-commit check for 58edcf3 has started.
⚪ 2024-08-14 16:23:05 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-14 16:23:18 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:28:16 UTC Pre-commit check for f3cf552 has started.
⚪ 2024-08-14 16:31:58 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-14 16:32:12 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:28:18 UTC Pre-commit check for f3cf552 has started.
⚪ 2024-08-14 16:32:01 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 16:32:15 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 16:28:20 UTC Pre-commit check for f3cf552 has started.
⚪ 2024-08-14 16:38:02 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-14 16:38:16 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 17:40:48 UTC Pre-commit check for 961c891 has started.
⚪ 2024-08-14 17:45:27 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-14 17:46:56 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 17:41:57 UTC Pre-commit check for 961c891 has started.
⚪ 2024-08-14 17:45:41 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-14 17:46:41 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 17:42:46 UTC Pre-commit check for 961c891 has started.
⚪ 2024-08-14 17:46:40 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-14 17:48:00 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 15:39:32 UTC Pre-commit check for 824b785 has started.
⚪ 2024-08-15 15:44:03 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-15 15:44:17 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 15:48:45 UTC Pre-commit check for 824b785 has started.
⚪ 2024-08-15 15:53:19 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 15:53:34 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 15:50:24 UTC Pre-commit check for 824b785 has started.
⚪ 2024-08-15 15:57:04 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-15 15:57:20 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 16:33:49 UTC Pre-commit check for c6df8b8 has started.
⚪ 2024-08-15 16:38:25 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 16:38:38 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 16:52:43 UTC Pre-commit check for c6df8b8 has started.
⚪ 2024-08-15 16:57:45 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-15 16:57:58 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 16:56:49 UTC Pre-commit check for c6df8b8 has started.
⚪ 2024-08-15 17:00:41 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-15 17:00:55 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 17:24:07 UTC Pre-commit check for 417db6c has started.
⚪ 2024-08-15 17:27:54 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 17:28:08 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 17:27:39 UTC Pre-commit check for 417db6c has started.
⚪ 2024-08-15 17:32:28 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-15 17:32:42 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 17:29:21 UTC Pre-commit check for 417db6c has started.
⚪ 2024-08-15 17:34:33 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-15 17:34:49 UTC Build failed. see the logs.

@Gazizonoki Gazizonoki force-pushed the replace-cpp-sdk-to-v2 branch from d2ec53a to e707446 Compare August 15, 2024 17:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 17:50:45 UTC Pre-commit check for 5c53b27 has started.
⚪ 2024-08-15 17:54:31 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-15 17:54:44 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 17:51:28 UTC Pre-commit check for 5c53b27 has started.
⚪ 2024-08-15 17:55:25 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-15 17:55:40 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚪ 2024-08-15 17:52:15 UTC Pre-commit check for 5c53b27 has started.
⚪ 2024-08-15 17:55:59 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-15 17:56:12 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

⚪ 2025-01-20 17:35:51 UTC Pre-commit check linux-x86_64-release-asan for c46c5bf has started.
⚪ 2025-01-20 17:36:12 UTC Artifacts will be uploaded here
⚪ 2025-01-20 17:39:46 UTC ya make is running...
🟡 2025-01-20 19:22:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13648 13513 0 49 58 28

⚪ 2025-01-20 19:23:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-20 19:36:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 142 0 1 17 25

⚪ 2025-01-20 19:36:58 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-01-20 19:48:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 41 0 0 1 23

🟢 2025-01-20 19:48:42 UTC Build successful.
🟢 2025-01-20 19:49:18 UTC ydbd size 3.6 GiB changed* by -1.5 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dbe9d9b merge: c46c5bf diff diff %
ydbd size 3 853 083 840 Bytes 3 851 521 712 Bytes -1.5 MiB -0.041%
ydbd stripped size 1 346 233 456 Bytes 1 346 903 952 Bytes +654.8 KiB +0.050%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

zverevgeny
zverevgeny previously approved these changes Jan 21, 2025
View reviewed changes
@Gazizonoki Gazizonoki force-pushed the replace-cpp-sdk-to-v2 branch from 9e8102c to 6a5ecae Compare January 21, 2025 14:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 14:40:18 UTC Pre-commit check linux-x86_64-release-asan for 6049d93 has started.
⚪ 2025-01-21 14:40:55 UTC Artifacts will be uploaded here
⚪ 2025-01-21 14:45:09 UTC ya make is running...
⚫ 2025-01-21 14:59:38 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 14:42:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6049d93 has started.
⚪ 2025-01-21 14:42:38 UTC Artifacts will be uploaded here
⚪ 2025-01-21 14:46:20 UTC ya make is running...
🔴 2025-01-21 14:51:54 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 15:04:29 UTC Pre-commit check linux-x86_64-release-asan for f6a91f6 has started.
⚪ 2025-01-21 15:04:42 UTC Artifacts will be uploaded here
⚪ 2025-01-21 15:08:25 UTC ya make is running...
🔴 2025-01-21 15:31:20 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 15:04:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for f6a91f6 has started.
⚪ 2025-01-21 15:05:12 UTC Artifacts will be uploaded here
⚪ 2025-01-21 15:09:00 UTC ya make is running...
🔴 2025-01-21 15:34:44 UTC Build failed, see the logs. Also see fail summary

asmyasnikov
asmyasnikov previously approved these changes Jan 21, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 15:55:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for ee8669b has started.
⚪ 2025-01-21 15:56:46 UTC Artifacts will be uploaded here
⚪ 2025-01-21 16:00:57 UTC ya make is running...
🔴 2025-01-21 16:06:36 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 15:56:22 UTC Pre-commit check linux-x86_64-release-asan for ee8669b has started.
⚪ 2025-01-21 15:57:12 UTC Artifacts will be uploaded here
⚪ 2025-01-21 16:00:46 UTC ya make is running...
⚫ 2025-01-21 16:09:52 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 16:11:28 UTC Pre-commit check linux-x86_64-release-asan for 50205a5 has started.
⚪ 2025-01-21 16:11:49 UTC Artifacts will be uploaded here
⚪ 2025-01-21 16:15:33 UTC ya make is running...
🟡 2025-01-21 17:15:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13672 13585 0 26 32 29

⚪ 2025-01-21 17:16:51 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-21 17:29:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
128 (only retried tests) 88 0 8 8 24

⚪ 2025-01-21 17:29:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-21 17:41:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 29 0 5 6 23

🟢 2025-01-21 17:42:11 UTC Build successful.
🟢 2025-01-21 17:42:49 UTC ydbd size 3.6 GiB changed* by -1.5 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 440c81e merge: 50205a5 diff diff %
ydbd size 3 853 560 184 Bytes 3 851 997 128 Bytes -1.5 MiB -0.041%
ydbd stripped size 1 346 385 168 Bytes 1 347 055 664 Bytes +654.8 KiB +0.050%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

⚪ 2025-01-21 16:14:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 50205a5 has started.
⚪ 2025-01-21 16:14:32 UTC Artifacts will be uploaded here
⚪ 2025-01-21 16:18:07 UTC ya make is running...
🟡 2025-01-21 17:21:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27959 25442 0 4 2381 132

⚪ 2025-01-21 17:24:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-21 17:36:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
200 (only retried tests) 81 0 0 0 119

🟢 2025-01-21 17:36:45 UTC Build successful.
🟠 2025-01-21 17:37:08 UTC Unmuted 10 tests
🟡 2025-01-21 17:37:36 UTC ydbd size 2.1 GiB changed* by +295.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 440c81e merge: 50205a5 diff diff %
ydbd size 2 216 956 600 Bytes 2 217 259 576 Bytes +295.9 KiB +0.014%
ydbd stripped size 468 691 280 Bytes 468 928 336 Bytes +231.5 KiB +0.051%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Gazizonoki Gazizonoki requested a review from spuchin January 21, 2025 17:50
adameat
adameat approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@adameat adameat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving without actually looking :(

@Gazizonoki Gazizonoki merged commit 5e0baa0 into ydb-platform:main Jan 22, 2025
12 checks passed
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@Gazizonoki @azevaykin
Replace cpp sdk to v3 (ydb-platform#7796)
c4768a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnv1 pnv1 pnv1 left review comments

@vitstn vitstn vitstn approved these changes

@asmyasnikov asmyasnikov asmyasnikov approved these changes

@dorooleg dorooleg dorooleg approved these changes

@adameat adameat adameat approved these changes

@zverevgeny zverevgeny zverevgeny approved these changes

@Alek5andr-Kotov Alek5andr-Kotov Alek5andr-Kotov approved these changes

@siarheivesialou siarheivesialou Awaiting requested review from siarheivesialou siarheivesialou is a code owner automatically assigned from ydb-platform/topics

@maximyurchuk maximyurchuk Awaiting requested review from maximyurchuk

@spuchin spuchin Awaiting requested review from spuchin

Assignees

@Gazizonoki Gazizonoki

@stanislav-shchetinin stanislav-shchetinin

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.