feat(ci): run tests in addition to lint

.github/workflows/run-lint.yml

@@ -1,7 +1,7 @@
 # Implicit requirements
 # runner must have `docker` and `curl` installed (true on github-runners)
 
-name: run-lint
+name: tests
 
 on:
   push:
@@ -57,3 +57,23 @@ jobs:
 
       - name: Check repository diff
         run: bash ./.github/scripts/check-work-copy-equals-to-committed.sh "auto-format broken"
+  tests:
+    name: run tests
+    concurrency:
+      group: tests-${{ github.ref }}
+      cancel-in-progress: true
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - name: install go
+        uses: actions/setup-go@v3
+        with:
+          go-version: "1.21"
+      - name: download dependencies
+        run: |
+          go mod download
+          echo "$HOME/go/bin" >> $GITHUB_PATH
+      - name: build ydbops
+        run: go build
+      - name: run tests
+        run: go test -v -p 1 ./... -args -ginkgo.v 

.golangci.yml

@@ -168,7 +168,7 @@ linters-settings:
       rangeValCopy:
         # Size in bytes that makes the warning trigger.
         # Default: 128
-        sizeThreshold: 32
+        sizeThreshold: 2048
         # Whether to check test functions.
         # Default: true
         skipTestFuncs: false

pkg/rolling/restarters/storage_k8s.go

@@ -30,7 +30,7 @@ func (r StorageK8sRestarter) RestartNode(node *Ydb_Maintenance.Node) error {
 func populateWithK8sRules(
 	nodes []*Ydb_Maintenance.Node,
 	spec FilterNodeParams,
-	FqdnToPodName map[string]string,
+	fqdnToPodName map[string]string,
 ) []*Ydb_Maintenance.Node {
 	if isInclusiveFilteringUnspecified(spec) {
 		return nodes
@@ -51,7 +51,7 @@ func populateWithK8sRules(
 				continue
 			}
 
-			if selectedHostFQDN == FqdnToPodName[node.Host] {
+			if selectedHostFQDN == fqdnToPodName[node.Host] {
 				selectedNodes = append(selectedNodes, node)
 				continue
 			}

pkg/rolling/rolling.go

@@ -118,9 +118,9 @@ func ExecuteRolling(
 	if err != nil {
 		logger.Errorf("Failed to complete restart: %+v", err)
 		return err
-	} else {
-		logger.Info("Restart completed successfully")
 	}
+
+	logger.Info("Restart completed successfully")
 	return nil
 }