Add --cleanup-on-exit #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The linter complains about excessive length of two core rolling restart functions. I have looked at it and it's probably better to leave as is, it's difficult to nicely shard these two. |
mvgorbunov
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: interrupting
ydbops restartleaves Requests and Permissions in YDB state.Sometimes it is desired, so we could continue current instance of rolling restart later (not implemented yet, with --continue flag).
But at other times leaving a high-priority request (not even permission) in YDB state leads to infrastructure teams not being able to take out nodes for maintenance, EVEN THOUGH the
ydbops restartprocess which spawned the request is long gone and does not need this request anymore.