Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maintenance duration with delays #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jorres
Copy link
Contributor

@Jorres Jorres commented Mar 8, 2025

Account for both --delay-between-restarts and --nodes-inflight when sending the request to CMS. Worst case scenario, CMS will give you all nodes that you asked for, which means that in total the duration must be:

  1. Determine base restart duration: reasonable single restart duration * reasonable retry number (currently, 60 and 3)
  2. Determine how many batches it will take (total requested nodes / --nodes-inflight)
  3. Total result will be: number of batches * (base restart duration + --delay-between-restarts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant