Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: erroneous profit and loss accounting in specification #62

Merged
merged 1 commit into from
Aug 19, 2023
Merged

fix: erroneous profit and loss accounting in specification #62

merged 1 commit into from
Aug 19, 2023

Conversation

Prakrit-Jain
Copy link
Contributor

Description

In the specified file: https://github.com/yearn/tokenized-strategy/blob/master/SPECIFICATION.md
At lines: 103, 104
It mentions that:

If totalAssets < newTotalAssets: the vault will record a loss
If totalAssets > newTotalAssets: the vault will record a profit

which should be :

If totalAssets < newTotalAssets: the vault will record a profit
If totalAssets > newTotalAssets: the vault will record a loss

Fixes #61

Checklist

  • I have run solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch

@Schlagonia Schlagonia changed the title Fixed erroneous profit and loss accounting in Specification.md fix: erroneous profit and loss accounting in specification Aug 19, 2023
@Schlagonia Schlagonia merged commit 8f6992d into yearn:master Aug 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schlagonia Schlagonia Schlagonia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous profit and loss accounting in Specification.md.
2 participants
@Prakrit-Jain @Schlagonia