feat: pass the storage pointer #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schlagonia
force-pushed
the
storage-pointer
branch
from
6cbcbe0
to
93e851a
Compare
Schlagonia
force-pushed
the
storage-pointer
branch
from
11ae272
to
5ae0f4a
Compare
fp-crypto
reviewed
Jan 26, 2024
src/TokenizedStrategy.sol
Outdated
| @@ -201,7 +201,7 @@ contract TokenizedStrategy { | |||
| * | |||
| * Loading the corresponding storage slot for the struct does not | |||
| * load any of the contents of the struct into memory. So the size | |||
| * has no effect on gas usage. | |||
| * wont increase gas usage. | |||
There was a problem hiding this comment.
Suggested change
| * wont increase gas usage. | |
| * won't increase gas usage. |
| @@ -498,15 +502,16 @@ contract TokenizedStrategy { | |||
| uint256 assets, | |||
| address receiver | |||
| ) external nonReentrant returns (uint256 shares) { | |||
| StrategyData storage S = _strategyStorage(); | |||
There was a problem hiding this comment.
So TLDR, external/public functions load the point, internal/private functions receive the pointer?
| ? shares | ||
| : shares.mulDiv(totalAssets(), supply, Math.Rounding.Down); | ||
| function convertToAssets(uint256 shares) external view returns (uint256) { | ||
| return _convertToAssets(_strategyStorage(), shares); |
There was a problem hiding this comment.
What is the advantage of separating the public and private methods like this? Code paths that have the storage pointer loaded can call the internal/private versions?
There was a problem hiding this comment.
Yes, _convertToAssets is used by multiple other functions within the contract. So any other function will call the internal one with the storage pointer already loaded
Yes I would have to think so. Added some additional asserts in the tests so that we now have 100% coverage across the TokenizedStrategy lines and functions c100407 |
fp-crypto
approved these changes
Jan 26, 2024
Schlagonia
added a commit
that referenced
this pull request
Jan 27, 2024
* feat: pass the storage pointer * chore: rebase * chore: formatting and comments * chore: rebase * fix: formatting functions * fix: test coverage * fix: remove lcov file * fix: ignore coverage file
Schlagonia
added a commit
that referenced
this pull request
Feb 4, 2024
* feat: version 302 * fix: remove increase and decrease allowance (#75) * feat: just track total assets (#73) * feat: just track total assets * fix: comments * feat: pass the storage pointer (#74) * feat: pass the storage pointer * chore: rebase * chore: formatting and comments * chore: rebase * fix: formatting functions * fix: test coverage * fix: remove lcov file * fix: ignore coverage file * fix: max redeem rounding (#83) * fix: use convert to shares * fix: tests * test: add check * test: fix invariants * fix: formatting (#78) * fix: naming * fix: pack struct (#81) * fix: pack struct further * fix: format * chore: dont use modifier require * chore: organize * chore: remove is functions * chore: add chain id to symbol * chore: organize * fix: revert symbol change * chore: fix symbol bakc * fix: minor changes (#82) * chore: remove min fee * fix: tests * build: cheaper reentrancy * chore: fix spech * feat: remove internal preview * feat: make factory immutable (#87) * feat: lower report costs (#76) * feat: only update unlock date * feat: dont burn unlocked (#77) * feat: burn shares once * feat: dont convert twice * fix: loss shares to burn * chore: comments * fix: report updates * fix: dont burn unless there is shares * chore: rebase to storage pointer * chore: organize reporting * chore: rebase * chore: final formatting and script (#88) * fix: solc * chore: comments * chore: deployment script * chore: yarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass the storage pointer to all internal functions to avoid reloading it multiple times a call.
Fixes # (issue)
Checklist