Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: formatting #78

Merged
merged 9 commits into from
Feb 1, 2024
Merged

fix: formatting #78

merged 9 commits into from
Feb 1, 2024

Conversation

Schlagonia
Copy link
Collaborator

@Schlagonia Schlagonia commented Jan 16, 2024 •
edited
Loading

Description

  • change init -> initialization to avoid python/vyper collisions
  • rename functions used by modifiers to 'require' instead of 'is' for clarity.
  • organize events
  • Pack struct tighter -- Removed 3 slots.
  • remove internal preview functions and add rounding param to internal converTo functions

Checklist

  • I have run solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch
  • I have updated the SPECIFICATION.md for any relevant changes

@Schlagonia Schlagonia changed the title fix: naming fix: formatting Jan 29, 2024
@Schlagonia Schlagonia changed the base branch from v3.0.2 to dev_302 January 31, 2024 23:44
fp-crypto
fp-crypto approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@fp-crypto fp-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@Schlagonia Schlagonia merged commit a3ace32 into dev_302 Feb 1, 2024
3 checks passed
@Schlagonia Schlagonia deleted the naming branch February 1, 2024 20:13
Schlagonia added a commit that referenced this pull request Feb 4, 2024
@Schlagonia
feat: version 3.0.2 (#85)
b2ad48b 
* feat: version 302

* fix: remove increase and decrease allowance (#75)

* feat: just track total assets (#73)

* feat: just track total assets

* fix: comments

* feat: pass the storage pointer (#74)

* feat: pass the storage pointer

* chore: rebase

* chore: formatting and comments

* chore: rebase

* fix: formatting functions

* fix: test coverage

* fix: remove lcov file

* fix: ignore coverage file

* fix: max redeem rounding (#83)

* fix: use convert to shares

* fix: tests

* test: add check

* test: fix invariants

* fix: formatting (#78)

* fix: naming

* fix: pack struct (#81)

* fix: pack struct further

* fix: format

* chore: dont use modifier require

* chore: organize

* chore: remove is functions

* chore: add chain id to symbol

* chore: organize

* fix: revert symbol change

* chore: fix symbol bakc

* fix: minor changes (#82)

* chore: remove min fee

* fix: tests

* build: cheaper reentrancy

* chore: fix spech

* feat: remove internal preview

* feat: make factory immutable (#87)

* feat: lower report costs (#76)

* feat: only update unlock date

* feat: dont burn unlocked (#77)

* feat: burn shares once

* feat: dont convert twice

* fix: loss shares to burn

* chore: comments

* fix: report updates

* fix: dont burn unless there is shares

* chore: rebase to storage pointer

* chore: organize reporting

* chore: rebase

* chore: final formatting and script (#88)

* fix: solc

* chore: comments

* chore: deployment script

* chore: yarn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fp-crypto fp-crypto fp-crypto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schlagonia @fp-crypto