-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calculate simple apy for balancer-aura vaults #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DISABLE_CURVE disables the curve exporter. Useful in dev if you don't need the curve exporter running as it currently takes a long time to load. * Defer circular references to the price magic module to avoid partially initialized module errors.
* Eg, this enables `brownie run scripts/debug_apy.py with_exception_handling` * Measure `vault.apy()` run time
murderteeth
changed the title
Calculate simple apy for balancer-aura vaults
feat: calculate simple apy for balancer-aura vaults
Feb 20, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #407
What I did:
I added an apy calculation for balancer-aura vaults. Because this calculation is based on the existing curve-convex calculation I also refactored the existing curve calculation, moving a lot of shared code to yearn/apy/common, yearn/apy/gauge, and yearn/apy/booster.
How I did it:
DISABLE_CURVE
envar for disabling the curve exporter during testing. This brought my cycle time down to 15 seconds when computing the bal-aura apy. I mostly ran this while testing:brownie run scripts/debug_apy.py with_exception_handling --network=mainnet
How to verify it:
I used Balancer Boosted Aave USD Pool yVault to test,
0xc5F3D11580c41cD07104e9AF154Fc6428bb93c73
. Following is output from the new calculation.Check results against the bb-a-usd pool on https://app.aura.finance/, for example:
Checklist:
Adding a Network
If the purpose of your PR is to add support for a new network, please copy the checklist from here into this PR conversation, and use it to track your changes.