Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reporting costs #192

Merged
merged 7 commits into from
Feb 3, 2024
Merged

fix: reporting costs #192

merged 7 commits into from
Feb 3, 2024

Conversation

Schlagonia
Copy link
Collaborator

@Schlagonia Schlagonia commented Jan 3, 2024 •
edited
Loading

Description

  • Lower gas cost of reports
  • Only mint or burn once based on ending state
  • remove multiple converTo calls.
  • Only adjust the fees for the report if we need to.
  • set unlock date to 0 instead of unlock rate for cheaper totalSupply() calls
  • only updates lastReport once.

Checklist

  • I have run vyper and solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch

@Schlagonia Schlagonia marked this pull request as draft January 3, 2024 16:05
@Schlagonia Schlagonia marked this pull request as ready for review January 21, 2024 03:30
@Schlagonia Schlagonia changed the title Features fix: reporting costs Jan 24, 2024
@Schlagonia Schlagonia merged commit 41f96ed into 3.0.2 Feb 3, 2024
7 checks passed
@Schlagonia Schlagonia deleted the features branch February 3, 2024 00:21
Schlagonia added a commit that referenced this pull request Feb 5, 2024
@Schlagonia
feat: version 3.0.2 (#188)
f869f7e 
* feat: update api and ape version

* chore: removals (#189)

* chore: remove increase and decrease allowances

* chore: remove open roles

* feat: add max loss to debt updates (#190)

* feat: use cloning for vaults (#191)

* feat: use cloning for vaults

* fix: scripts

* chore: fix interfaces

* chore: lower case factory

* fix: update to strategy changes

* feat: add to queue flag (#195)

* fix: updated strategy branch

* feat: minor fixes (#194)

* fix: redeem corrections

* chore: dont burn zero shares

* fix: use updated strategy storage

* fix: rebase

* chore: bump oz version

* fix: oz 4626 fix

* fix: lossy test

* fix: round down in max redeem

* fix: comment

* chore: ignore snapshot

* test: add foundry tests (#196)

* chore: setup foundry test

* chore: add remappings

* forge install: erc4626-tests

* test: add foundry fuzzing tests

* fix: max uint deposit limit

* fix: test strategy

* fix: foundry runner

* fix: clamp overflow

* fix: default tests

* chore: clean up linting

* fix: new strategy version

* fix: reporting costs (#192)

* test: for no locking

* chore: cheaper reports

* chore: track current debt

* chore: lower unlocked gas

* fix: set to 0

* build: only burn or mint (#193)

* build: only burn or mint

* build: target end supply

* chore: comments

* fix: comments

* fix: strategy changes

* chore: rebase

* fix: decimal type

* chore: deployment and interfaces

* fix: black

* chore: updated strategy branch

* fix: foundry remapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fp-crypto fp-crypto fp-crypto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schlagonia @fp-crypto